Skip to content

Fix error in package script for (Arch) Linux #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Fix error in package script for (Arch) Linux #691

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f19b5d6
Fix error in package script for (Arch) Linux
glubsy Jul 24, 2020
49a1beb
Avoid using workarounds in package script
glubsy Jul 24, 2020
f0adf35
Add helpful message in build files are missing
glubsy Jul 24, 2020
d193e1f
Fix typo in error message
glubsy Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ def copy_files_to_package(destpath, packages, with_so):
shutil.copy("run.py", op.join(destpath, "run.py"))
extra_ignores = ["*.so"] if not with_so else None
copy_packages(packages, destpath, extra_ignores=extra_ignores)
# include locale files if they are built otherwise exit as it will break
# the localization
if not op.exists("build/locale"):
print("Locale files are missing. Have you run \"build.py --loc\"? Exiting...")
return
# include help files if they are built otherwise exit as they should be included?
if not op.exists("build/help"):
print("Help files are missing. Have you run \"build.py --doc\"? Exiting...")
return
shutil.copytree(op.join("build", "help"), op.join(destpath, "help"))
shutil.copytree(op.join("build", "locale"), op.join(destpath, "locale"))
compileall.compile_dir(destpath)
Expand Down Expand Up @@ -152,11 +161,11 @@ def package_windows():
# include locale files if they are built otherwise exit as it will break
# the localization
if not op.exists("build/locale"):
print("Locale files not built, exiting...")
print("Locale files are missing. Have you run \"build.py --loc\"? Exiting...")
return
# include help files if they are built otherwise exit as they should be included?
if not op.exists("build/help"):
print("Help files not built, exiting...")
print("Help files are missing. Have you run \"build.py --doc\"? Exiting...")
return
# create version information file from template
try:
Expand Down