Skip to content

Conversation

@fremzuck
Copy link

@fremzuck fremzuck commented Jul 4, 2025

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • [ x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • [ x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (403c29f) to head (85156e6).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2324      2335   +11     
  Branches       357       357           
=========================================
+ Hits          2324      2335   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"minutes": "{0} นาที",
"hour": "1 ชั่วโมง",
"hours": "{0} ชั่วโมง",
"week": "1 สัปดาห์",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fremzuck thanks for the contribution! Mind adding some unit tests for these new cases?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a problem when using the .humanize(locale='th-th') function when the received date is more than 7 days, so I added this part. I tested it on my machine and it works fine.

What test result you want to review ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a couple of basic unit tests to test this locale usage like other locales in the test_locales.py test file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Added

@jadchaar
Copy link
Member

jadchaar commented Jul 8, 2025

Hi @fremzuck all the tests are failing right now. I am working on fixing Windows tests, but mac and linux should at least pass

@jadchaar
Copy link
Member

jadchaar commented Aug 5, 2025

Seems to be done by #1218

@jadchaar jadchaar closed this Aug 5, 2025
@jadchaar
Copy link
Member

jadchaar commented Aug 5, 2025

@fremzuck feel free to add the quarter translations + tests (updated with the PR changes from #1218). Once those are done and tests pass on mac + linux (windows is pending a change on our side), we should be good to merge this. Feel free to re-open the PR once the changes are made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants