Skip to content

fix: adding persian names of months and month-abbreviations and day-abbreviations in Gregorian calendar #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jadchaar merged 5 commits into from
Oct 29, 2024
+41 −25
Merged

fix: adding persian names of months and month-abbreviations and day-abbreviations in Gregorian calendar #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a50a98
fix: adding persian names of months in Gregorian calendar
Apr 17, 2024
ab1ff62
test: running all tests
Apr 17, 2024
9610acd
Merge branch 'master' into fix-farsi-months
jadchaar Oct 24, 2024
ee2926c
test: add tests for weekdays in farsi
fouladi Oct 25, 2024
cd6db81
test: add 2 more tests for month-name and mont-abbr.
fouladi Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 34 additions & 25 deletions arrow/locales.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3385,33 +3385,33 @@ class FarsiLocale(Locale):

month_names = [
"",
"January",
"February",
"March",
"April",
"May",
"June",
"July",
"August",
"September",
"October",
"November",
"December",
"ژانویه",
"فوریه",
"مارس",
"آوریل",
"مه",
"ژوئن",
"ژوئیه",
"اوت",
"سپتامبر",
"اکتبر",
"نوامبر",
"دسامبر",
]
month_abbreviations = [
"",
"Jan",
"Feb",
"Mar",
"Apr",
"May",
"Jun",
"Jul",
"Aug",
"Sep",
"Oct",
"Nov",
"Dec",
"ژانویه",
"فوریه",
"مارس",
"آوریل",
"مه",
"ژوئن",
"ژوئیه",
"اوت",
"سپتامبر",
"اکتبر",
"نوامبر",
"دسامبر",
]

day_names = [
Expand All @@ -3424,7 +3424,16 @@ class FarsiLocale(Locale):
"شنبه",
"یکشنبه",
]
day_abbreviations = ["", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"]
day_abbreviations = [
"",
"دو شنبه",
"سه شنبه",
"چهارشنبه",
"پنجشنبه",
"جمعه",
"شنبه",
"یکشنبه",
]


class HebrewLocale(Locale):
Expand Down
7 changes: 7 additions & 0 deletions tests/test_locales.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,6 +1463,13 @@ def test_timeframes(self):
assert self.locale._format_timeframe("months", 2) == "2 ماه"
assert self.locale._format_timeframe("years", 2) == "2 سال"

def test_weekday(self):
fa = arrow.Arrow(2024, 10, 25, 17, 30, 00)
assert self.locale.day_name(fa.isoweekday()) == "جمعه"
assert self.locale.day_abbreviation(fa.isoweekday()) == "جمعه"
assert self.locale.month_name(fa.month) == "اکتبر"
assert self.locale.month_abbreviation(fa.month) == "اکتبر"


@pytest.mark.usefixtures("lang_locale")
class TestNepaliLocale:
Expand Down