-
-
Notifications
You must be signed in to change notification settings - Fork 705
Add quarter granularity #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarter granularity #1048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2218 2221 +3
Branches 348 349 +1
=========================================
+ Hits 2218 2221 +3
Continue to review full report at Codecov.
|
anishnya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1cb4b22 to
d727d5b
Compare
.pre-commit-config.yaml
Outdated
| - id: isort | ||
| - repo: https://github.com/asottile/pyupgrade | ||
| rev: v2.29.0 | ||
| rev: v2.23.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase this file from master since it was updated in a recent commit.
.pre-commit-config.yaml
Outdated
| args: [--safe, --quiet, --target-version=py36] | ||
| - repo: https://github.com/pycqa/flake8 | ||
| rev: 4.0.1 | ||
| additional_dependencies: [regex==2020.1.8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary if the CI build for this change passes when the PR is submitted. The lint error you are seeing must be a local caching issue. Try deleting the pre-commit cache: rm -rf /Users/ali/.cache/pre-commit/.
jadchaar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it would be good to add a few more tests :)!
jadchaar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the awesome contribution @Alig1493!
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
#1019
regex==2020.1.8to bypass errors encountered during linting checks. I.E:quartergranularity options to humanize.quartergranularity