some small changes to APA extension

[leggewie]

• fix minor spelling mistake
• remove *.inactive sources snippet after installation of armbian-common to image
• make handling of INSTALL_RECOMMENDS more robust

[coderabbitai]

Walkthrough

• INSTALL_RECOMMENDS changed from "no"/"yes" to "no-install-recommends"/"install-recommends" and is now used as a boolean-style flag passed to apt-get (e.g., --no-install-recommends or --install-recommends) when installing armbian-common and armbian-bsp.
• After apt-get install, the script now removes /etc/apt/sources.list.d/armbian-apa.list.inactive from the image.
• Fixed a comment typo: "environmnent" → "environment".
• Removed the direct apt-get line that installed armbian-desktop-${DESKTOP_ENVIRONMENT,,}; the DESKTOP_ENVIRONMENT case now only calls display_alert.
• No other control-flow or public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• enable APA extension for Debian Unstable builds #8359 — Also modifies the APA extension; enables APA for Debian Unstable and touches related install behavior.
• extensions: add APA extension #8133 — Changes APA install logic and install-recommends handling in extensions/apa.sh.
• extensions: add missing "install" instruction to APA extension #8483 — Adjusts apt-get invocation and --install-recommends usage for armbian-desktop in extensions/apa.sh.

Suggested reviewers

• rpardini
• igorpecovnik

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5bbb7e1 and 43dc0f1.

📒 Files selected for processing (1)

• extensions/apa.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• extensions/apa.sh

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🔭 Outside diff range comments (1)

extensions/apa.sh (1)

18-24: Update --install-recommends flag usage

The --install-recommends option is a boolean flag and should not be given a value. Replace the current invocation to match the expected syntax:

• File: extensions/apa.sh, around lines 18–24

-	chroot_sdcard_apt_get install --install-recommends=yes "armbian-desktop-${DESKTOP_ENVIRONMENT,,}"
+	chroot_sdcard_apt_get install --install-recommends armbian-desktop-${DESKTOP_ENVIRONMENT,,}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 214fd20 and 5bbb7e1.

📒 Files selected for processing (1)

• extensions/apa.sh (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-05-16T15:34:34.672Z

Learnt from: Grippy98
PR: armbian/build#8202
File: config/desktop/trixie/environments/gnome/armbian/create_desktop_package.sh:2-3
Timestamp: 2025-05-16T15:34:34.672Z
Learning: The shell scripts in the Armbian build system's desktop configuration files, such as config/desktop/trixie/environments/gnome/armbian/create_desktop_package.sh, rely on environment variables like $SRC and $destination that are expected to be set externally before the script is executed.

Applied to files:

• extensions/apa.sh

🔇 Additional comments (1)

extensions/apa.sh (1)

16-16: Cleanup of inactive sources file looks good.

Using chroot_sdcard rm -f safely removes the stale list file without erroring if absent. LGTM.