Skip to content

Conversation

@leggewie
Copy link
Collaborator

gnome-bluetooth in later releases is only transitional package to gnome-bluetooth-sendto. update config-base package definition for noble and trixie i3-wm.

#FTBFS
Closes: #8501

…an#8501)

gnome-bluetooth in later releases is only transitional package to
gnome-bluetooth-sendto.  update config-base package definition for
noble and trixie i3-wm.
@leggewie leggewie requested a review from igorpecovnik as a code owner August 14, 2025 16:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2025

Walkthrough

Replaces the package name gnome-bluetooth with gnome-bluetooth-sendto in two package list files for the i3-wm desktop environment: one under Debian Trixie and one under Ubuntu Noble. No other changes are made.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Replace gnome-bluetooth with gnome-bluetooth-sendto in i3-wm packages for Trixie builds (#8501)

Assessment against linked issues: Out-of-scope changes

Code Change Explanation
Replace gnome-bluetooth with gnome-bluetooth-sendto (config/desktop/noble/environments/i3-wm/config_base/packages) Issue #8501 concerns Debian Trixie only; changing Noble is not referenced in the objectives.

Possibly related PRs

Suggested labels

Desktop, Needs review, size/small

Suggested reviewers

  • EvilOlaf
  • igorpecovnik

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 08 Milestone: Third quarter release size/small PR with less then 50 lines Desktop Graphical user interface Needs review Seeking for review labels Aug 14, 2025
@coderabbitai coderabbitai bot requested a review from EvilOlaf August 14, 2025 16:38
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dfb7c4f and 562e695.

📒 Files selected for processing (2)
  • config/desktop/noble/environments/i3-wm/config_base/packages (1 hunks)
  • config/desktop/trixie/environments/i3-wm/config_base/packages (1 hunks)
🔇 Additional comments (1)
config/desktop/noble/environments/i3-wm/config_base/packages (1)

45-45: LGTM for Noble — gnome-bluetooth-sendto is the correct package, but repo contains other gnome-bluetooth entries

Verified: Ubuntu Noble's gnome-bluetooth is a transitional package that depends on gnome-bluetooth-sendto (packages.ubuntu.com).

Remaining exact matches in the repo:

  • config/desktop/bookworm/environments/xmonad/config_base/packages:41 — gnome-bluetooth
  • config/desktop/bookworm/environments/i3-wm/config_base/packages:44 — gnome-bluetooth
  • config/desktop/jammy/environments/i3-wm/config_base/packages:45 — gnome-bluetooth
  • config/desktop/jammy/environments/xmonad/config_base/packages:41 — gnome-bluetooth

If this change was only meant for Noble, no further action is required. If you want to standardize across releases, please update those files (replace with gnome-bluetooth-sendto or the appropriate package for each release) and re-run the scan.

@igorpecovnik igorpecovnik merged commit 4f8fdbc into armbian:main Aug 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Desktop Graphical user interface Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

[Bug]: Package 'gnome-bluetooth' has no installation candidate while building Trixie image

2 participants