Skip to content

Conversation

@paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Jul 27, 2025

Description

Bump rockchip edge to kernel 6.16.

  • patches ported to v6.16 (libreelec, ssv6051, esp8089 mainly)
  • kernel config updated

GitHub issue reference:
Jira reference number AR-2718

How Has This Been Tested?

  • Tested on a live rk322x-box installation, everything works out of the box
  • WIP: tested on a live tinkerboard installation eveything works except ethernet fails to work when plugged in during boot (similar to this)

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published in downstream modules

@paolosabatino paolosabatino requested a review from a team July 27, 2025 13:42
@paolosabatino paolosabatino added the Work in progress Unfinished / work in progress label Jul 27, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 27, 2025

Walkthrough

This change updates the Rockchip "edge" kernel configuration by bumping the kernel version from 6.15 to 6.16 in the family configuration file. Additionally, the kernel configuration file for linux-rockchip-edge is modified by enabling, disabling, or removing several kernel module options, including the removal of CONFIG_USELIB, disabling CONFIG_IP_DCCP, adjusting the position and status of CONFIG_DRM_SIMPLEDRM and CONFIG_TI_ADS8344, and removing CONFIG_CRYPTO_TEST and CONFIG_CRYPTO_SHA2_ARM_CE. No changes to exported or public entities are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Suggested labels

Ready to merge, 08, Needs review, size/small, Hardware, Patches

Suggested reviewers

  • igorpecovnik
  • amazingfate

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 08 Milestone: Third quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jul 27, 2025
@coderabbitai coderabbitai bot requested a review from amazingfate July 27, 2025 13:42
@coderabbitai coderabbitai bot added Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines labels Jul 27, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
config/kernel/linux-rockchip-edge.config (1)

1558-1562: Validate the necessity of the TI_ADS8344 ADC driver

CONFIG_TI_ADS8344=m adds an SPI ADC that is not present on most Rockchip boards.
Enabling unnecessary drivers increases kernel size and build time. Unless you have boards that actually expose this chip on the SPI bus, you can drop it to keep the defconfig minimal.

-CONFIG_TI_ADS8344=m
+# CONFIG_TI_ADS8344 is not set
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67e4ab7 and c087981.

⛔ Files ignored due to path filters (132)
  • patch/kernel/archive/rockchip-6.15/patches.libreelec/linux-0011-v4l2-from-list.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/0000.patching_config.yaml is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/armbian.series is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/dt/rk322x-box.dts is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/dt/rk3288-xt-q8l-v10.dts is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/kernel-6.8-tools-cgroup-makefile.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/libreelec.series is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/Makefile is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/README.rk322x-overlays is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/README.rockchip-overlays is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-bt-8723cs.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-hs-lv.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-hs.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-stability.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-330.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-528.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-660.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-800.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-ddr-ph180.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-ddr-ph45.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-hs200.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-pins.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-fixup.scr-cmd is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-ir-wakeup.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf-default.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf1.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf3.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf4.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf5.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf6.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf7.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf8.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-nand.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-usb-otg-peripheral.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rk322x-wlan-alt-wiring.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-ds1307.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-ds1307.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-fixup.scr-cmd is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c1.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c1.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c4.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c4.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm1.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm3.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi0.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi0.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi2.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev0.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev0.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev2.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart1.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart1.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart2.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart2.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart3.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart3.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart4.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart4.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-w1-gpio.dtbo is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/overlay/rockchip-w1-gpio.dtso is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/bt-broadcom-serdev-workaround.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/clk-rk322x-composite-mmc-clk.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/clk-rockchip-max-frac-divider.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/driver-rk322x-audio-codec.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/driver-rk3288-gpiomem.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/driver-tinkerboard-alc4040-codec.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rk322x-plane-overlay.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rk322x-yuv-10bit-modes.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rockchip-hardware-cursor.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-fan.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-hevc-rga.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-mali-gpu.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-regulator-fix.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk322x-iep-node.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk322x-pinctrl-nand.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-disable-serial-dma.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-fix-mmc-aliases.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-gpu-500mhz-opp.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-pinctrl-spi2.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-thermal-rearrange-zones.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-bt-rtl8723bs.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-bt-uart-pins.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-hevc-rga.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-sdio-wifi.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-sdmmc-properties.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-spi-interface.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/dts-veyron-flag-cache-flush.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-overlay-compilation-support.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-overlay-configfs.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-restart-handler-for-act8846.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-rk3288-reset-on-wake-quirk.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-wait-peripheral.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-wait-time.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-nak-gadget.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-fix-reboot-from-kwiboo.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-increase-spdif-dma-burst.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-linux-export-mm-trace-rss-stats.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-01-fix-periodic-transfers.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-02-add-support-for-interleaved-transfers.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-04-bigger-mcode-buffer.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-05-fix-unbalanced-power-down.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-06-fix-buffer-underruns.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-rk322x-gpio-ir-driver.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/general-rockchip-various-fixes.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/ir-keymap-rk322x-box.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/ir-keymap-xt-q8l-v10.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/misc-tinkerboard-spi-interface.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/mmc-tinkerboard-sdmmc-reboot-fix.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-01-sipv2-calls.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-02-sip-constants.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-03-dfi-driver.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-04-driver.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dwc2-no-clock-gating.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-usb-reset-props.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-ath9k-no-bulk-EP3-EP4.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-brcmfmac-add-bcm43342.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-brcmfmac-ap6330-firmware.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-driver-esp8089.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-driver-ssv6051.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-0002-rockchip-from-list.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-0011-v4l2-from-list.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1000-drm-rockchip.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1001-v4l2-rockchip.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1002-for-libreelec.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-2000-v4l2-wip-rkvdec-hevc.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-2001-v4l2-wip-iep-driver.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip-6.16/series.conf is excluded by !patch/**
📒 Files selected for processing (2)
  • config/kernel/linux-rockchip-edge.config (2 hunks)
  • config/sources/families/rockchip.conf (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: EvilOlaf
PR: armbian/build#8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.
Learnt from: EvilOlaf
PR: armbian/build#8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.
Learnt from: EvilOlaf
PR: armbian/build#8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.
Learnt from: The-going
PR: armbian/build#8147
File: config/sources/families/include/sunxi64_common.inc:38-39
Timestamp: 2025-04-30T16:16:47.150Z
Learning: The Armbian build system references Linux kernel versions in the form "tag:v6.14.4" in the KERNELBRANCH variable, even when point release tags might not be directly visible in the upstream repository in the same form.
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: lanefu
PR: armbian/build#8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT is a valid kernel configuration option in Linux kernel 6.12 and later versions, despite not being present in earlier versions like 6.9/6.10-rc.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
Learnt from: lanefu
PR: armbian/build#8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT was introduced in Linux kernel 4.14.330 (November 2023) and enables BPF-programmable network devices that can operate in Layer 3 or Layer 2 mode. It's a valid configuration option in modern kernels including 6.12.
Learnt from: pyavitz
PR: armbian/build#8421
File: config/kernel/linux-sunxi64-edge.config:82-83
Timestamp: 2025-07-26T11:14:41.678Z
Learning: In Linux kernel 6.13 and later, CONFIG_ZBUD was deprecated and is scheduled for removal in kernel 6.15. The zbud compressed page allocator was found to consume more memory than alternatives like zsmalloc. Therefore, CONFIG_ZSWAP_ZPOOL_DEFAULT_ZBUD becomes obsolete in current kernels, and make defconfig will auto-correct by removing such deprecated options. This demonstrates how kernel defconfigs can be backwards compatible but not forward compatible.
config/kernel/linux-rockchip-edge.config (12)

Learnt from: libiunc
PR: #8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.

Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.

Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:1058-1061
Timestamp: 2025-07-26T10:43:10.097Z
Learning: When reviewing kernel configuration files, it's important to verify the actual Kconfig dependencies in the source code rather than making assumptions about configuration validity, especially for complex subsystems like I2C drivers where the dependency relationships may be more nuanced than initially apparent.

Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.

Learnt from: pyavitz
PR: #8383
File: config/kernel/linux-sunxi64-edge.config:57-64
Timestamp: 2025-07-15T21:09:23.252Z
Learning: In Linux kernel configuration, when CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y is set, the ondemand governor is implicitly enabled by default, making the explicit CONFIG_CPU_FREQ_GOV_ONDEMAND=y line redundant. The make menuconfig tool automatically removes such redundant lines. This behavior applies to CPU frequency governor configurations in general - setting a default governor automatically enables that governor.

Learnt from: pyavitz
PR: #8388
File: config/boards/kickpik2b.conf:1-14
Timestamp: 2025-07-17T04:12:33.125Z
Learning: In the Armbian build system, board configuration files (*.conf) follow a project standard of not including shebang lines, even though they contain bash code and are sourced by the build system. This is an established Armbian convention that individual contributors are expected to follow, and changes to this standard would require broader project maintainer approval.

Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.

Learnt from: EvilOlaf
PR: #8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Learnt from: lanefu
PR: #8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT is a valid kernel configuration option in Linux kernel 6.12 and later versions, despite not being present in earlier versions like 6.9/6.10-rc.

Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:82-83
Timestamp: 2025-07-26T11:14:41.678Z
Learning: In Linux kernel 6.13 and later, CONFIG_ZBUD was deprecated and is scheduled for removal in kernel 6.15. The zbud compressed page allocator was found to consume more memory than alternatives like zsmalloc. Therefore, CONFIG_ZSWAP_ZPOOL_DEFAULT_ZBUD becomes obsolete in current kernels, and make defconfig will auto-correct by removing such deprecated options. This demonstrates how kernel defconfigs can be backwards compatible but not forward compatible.

Learnt from: lanefu
PR: #8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT was introduced in Linux kernel 4.14.330 (November 2023) and enables BPF-programmable network devices that can operate in Layer 3 or Layer 2 mode. It's a valid configuration option in modern kernels including 6.12.

Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:1058-1061
Timestamp: 2025-07-26T11:17:56.856Z
Learning: I2C_DESIGNWARE_SLAVE is a bool configuration option in Linux kernel Kconfig, not tristate. This means it can only be set to 'y' (enabled) or 'n' (disabled), never 'm' (module). When enabled, the slave functionality is compiled into the I2C_DESIGNWARE_CORE driver, regardless of whether the core driver is built-in or as a module.

config/sources/families/rockchip.conf (8)

Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.

Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.

Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.

Learnt from: Grippy98
PR: #8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.

Learnt from: The-going
PR: #8147
File: config/sources/families/include/sunxi64_common.inc:38-39
Timestamp: 2025-04-30T16:16:47.150Z
Learning: The Armbian build system references Linux kernel versions in the form "tag:v6.14.4" in the KERNELBRANCH variable, even when point release tags might not be directly visible in the upstream repository in the same form.

Learnt from: libiunc
PR: #8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.

Learnt from: EvilOlaf
PR: #8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.

Learnt from: rpardini
PR: #8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.

🧬 Code Graph Analysis (1)
config/sources/families/rockchip.conf (2)
config/sources/mainline-kernel.conf.sh (1)
  • mainline_kernel_decide_version__upstream_release_candidate_number (8-14)
lib/functions/compilation/armbian-kernel.sh (1)
  • armbian_kernel_config__netkit (46-53)
🔇 Additional comments (2)
config/sources/families/rockchip.conf (1)

57-60: Confirm the follow-up switch from RC to the final 6.16 tag

KERNEL_MAJOR_MINOR="6.16" triggers the mainline-kernel_decide_version__upstream_release_candidate_number() hook, which currently pins KERNELBRANCH to tag:v6.16-rc7.
Unless this file (or the hook) is updated after the final 6.16 release, users will continue to receive the -rc kernel. Please plan a follow-up bump (or remove the hard-coded RC logic) so that stable images aren’t built on a release candidate.

config/kernel/linux-rockchip-edge.config (1)

1129-1132: Switching SIMPLEDRM from built-in to module may drop early framebuffer output

CONFIG_DRM_SIMPLEDRM=m means the generic firmware-/DT-backed framebuffer is no longer available until modules load.
On boards without an early native DRM driver (or if the rootfs is on slow media), this can leave the screen blank during boot and hide kernel panics. Verify that:

  1. Rockchip DRM really probes early enough on every supported board.
  2. SimpleDRM was not previously relied on for splash/console.

If early output is still desired, consider keeping it built-in:

-CONFIG_DRM_SIMPLEDRM=m
+CONFIG_DRM_SIMPLEDRM=y

@leggewie leggewie self-requested a review July 28, 2025 12:43
Copy link
Collaborator

@leggewie leggewie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and was boot tested. remaining problems were documented here. thank you for your work.

@leggewie leggewie merged commit 96fe7de into armbian:main Jul 28, 2025
1 check passed
@paolosabatino paolosabatino deleted the rockchip-edge-6.16 branch July 28, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more size/small PR with less then 50 lines Work in progress Unfinished / work in progress

Development

Successfully merging this pull request may close these issues.

2 participants