-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
bump rockchip edge to kernel 6.16 #8435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the Rockchip "edge" kernel configuration by bumping the kernel version from 6.15 to 6.16 in the family configuration file. Additionally, the kernel configuration file for linux-rockchip-edge is modified by enabling, disabling, or removing several kernel module options, including the removal of Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/kernel/linux-rockchip-edge.config (1)
1558-1562: Validate the necessity of the TI_ADS8344 ADC driver
CONFIG_TI_ADS8344=madds an SPI ADC that is not present on most Rockchip boards.
Enabling unnecessary drivers increases kernel size and build time. Unless you have boards that actually expose this chip on the SPI bus, you can drop it to keep the defconfig minimal.-CONFIG_TI_ADS8344=m +# CONFIG_TI_ADS8344 is not set
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (132)
patch/kernel/archive/rockchip-6.15/patches.libreelec/linux-0011-v4l2-from-list.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/0000.patching_config.yamlis excluded by!patch/**patch/kernel/archive/rockchip-6.16/armbian.seriesis excluded by!patch/**patch/kernel/archive/rockchip-6.16/dt/rk322x-box.dtsis excluded by!patch/**patch/kernel/archive/rockchip-6.16/dt/rk3288-xt-q8l-v10.dtsis excluded by!patch/**patch/kernel/archive/rockchip-6.16/kernel-6.8-tools-cgroup-makefile.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/libreelec.seriesis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/Makefileis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/README.rk322x-overlaysis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/README.rockchip-overlaysis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-bt-8723cs.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-hs-lv.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-hs.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-cpu-stability.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-330.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-528.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-660.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-ddr3-800.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-ddr-ph180.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-ddr-ph45.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-hs200.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc-pins.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-emmc.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-fixup.scr-cmdis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-ir-wakeup.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf-default.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf1.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf2.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf3.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf4.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf5.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf6.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf7.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-led-conf8.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-nand.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-usb-otg-peripheral.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rk322x-wlan-alt-wiring.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-ds1307.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-ds1307.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-fixup.scr-cmdis excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c1.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c1.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c4.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-i2c4.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm1.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm2.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-pwm3.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi0.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi0.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi2.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spi2.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev0.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev0.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev2.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-spidev2.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart1.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart1.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart2.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart2.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart3.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart3.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart4.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-uart4.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-w1-gpio.dtbois excluded by!patch/**patch/kernel/archive/rockchip-6.16/overlay/rockchip-w1-gpio.dtsois excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/bt-broadcom-serdev-workaround.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/clk-rk322x-composite-mmc-clk.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/clk-rockchip-max-frac-divider.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/driver-rk322x-audio-codec.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/driver-rk3288-gpiomem.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/driver-tinkerboard-alc4040-codec.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rk322x-plane-overlay.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rk322x-yuv-10bit-modes.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/drm-rockchip-hardware-cursor.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-fan.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-hevc-rga.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-mali-gpu.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-miqi-regulator-fix.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk322x-iep-node.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk322x-pinctrl-nand.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-disable-serial-dma.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-fix-mmc-aliases.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-gpu-500mhz-opp.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-pinctrl-spi2.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-rk3288-thermal-rearrange-zones.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-bt-rtl8723bs.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-bt-uart-pins.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-hevc-rga.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-sdio-wifi.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-sdmmc-properties.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-tinkerboard-spi-interface.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/dts-veyron-flag-cache-flush.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-overlay-compilation-support.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-overlay-configfs.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-add-restart-handler-for-act8846.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-rk3288-reset-on-wake-quirk.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-wait-peripheral.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-fix-wait-time.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-dwc2-nak-gadget.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-fix-reboot-from-kwiboo.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-increase-spdif-dma-burst.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-linux-export-mm-trace-rss-stats.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-01-fix-periodic-transfers.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-02-add-support-for-interleaved-transfers.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-04-bigger-mcode-buffer.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-05-fix-unbalanced-power-down.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-pl330-06-fix-buffer-underruns.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-rk322x-gpio-ir-driver.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/general-rockchip-various-fixes.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/ir-keymap-rk322x-box.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/ir-keymap-xt-q8l-v10.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/misc-tinkerboard-spi-interface.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/mmc-tinkerboard-sdmmc-reboot-fix.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-01-sipv2-calls.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-02-sip-constants.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-03-dfi-driver.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dmc-driver-04-driver.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-dwc2-no-clock-gating.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/rk322x-usb-reset-props.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-ath9k-no-bulk-EP3-EP4.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-brcmfmac-add-bcm43342.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-brcmfmac-ap6330-firmware.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-driver-esp8089.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.armbian/wifi-driver-ssv6051.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-0002-rockchip-from-list.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-0011-v4l2-from-list.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1000-drm-rockchip.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1001-v4l2-rockchip.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-1002-for-libreelec.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-2000-v4l2-wip-rkvdec-hevc.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/patches.libreelec/linux-2001-v4l2-wip-iep-driver.patchis excluded by!patch/**patch/kernel/archive/rockchip-6.16/series.confis excluded by!patch/**
📒 Files selected for processing (2)
config/kernel/linux-rockchip-edge.config(2 hunks)config/sources/families/rockchip.conf(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: EvilOlaf
PR: armbian/build#8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.
Learnt from: EvilOlaf
PR: armbian/build#8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.
Learnt from: EvilOlaf
PR: armbian/build#8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
Learnt from: rpardini
PR: armbian/build#8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.
Learnt from: The-going
PR: armbian/build#8147
File: config/sources/families/include/sunxi64_common.inc:38-39
Timestamp: 2025-04-30T16:16:47.150Z
Learning: The Armbian build system references Linux kernel versions in the form "tag:v6.14.4" in the KERNELBRANCH variable, even when point release tags might not be directly visible in the upstream repository in the same form.
Learnt from: libiunc
PR: armbian/build#8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: lanefu
PR: armbian/build#8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT is a valid kernel configuration option in Linux kernel 6.12 and later versions, despite not being present in earlier versions like 6.9/6.10-rc.
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Learnt from: Grippy98
PR: armbian/build#8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
Learnt from: lanefu
PR: armbian/build#8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT was introduced in Linux kernel 4.14.330 (November 2023) and enables BPF-programmable network devices that can operate in Layer 3 or Layer 2 mode. It's a valid configuration option in modern kernels including 6.12.
Learnt from: pyavitz
PR: armbian/build#8421
File: config/kernel/linux-sunxi64-edge.config:82-83
Timestamp: 2025-07-26T11:14:41.678Z
Learning: In Linux kernel 6.13 and later, CONFIG_ZBUD was deprecated and is scheduled for removal in kernel 6.15. The zbud compressed page allocator was found to consume more memory than alternatives like zsmalloc. Therefore, CONFIG_ZSWAP_ZPOOL_DEFAULT_ZBUD becomes obsolete in current kernels, and make defconfig will auto-correct by removing such deprecated options. This demonstrates how kernel defconfigs can be backwards compatible but not forward compatible.
config/kernel/linux-rockchip-edge.config (12)
Learnt from: libiunc
PR: #8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:1058-1061
Timestamp: 2025-07-26T10:43:10.097Z
Learning: When reviewing kernel configuration files, it's important to verify the actual Kconfig dependencies in the source code rather than making assumptions about configuration validity, especially for complex subsystems like I2C drivers where the dependency relationships may be more nuanced than initially apparent.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-06-16T03:24:00.458Z
Learning: In Armbian board configuration files (.csc), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features.
Learnt from: pyavitz
PR: #8383
File: config/kernel/linux-sunxi64-edge.config:57-64
Timestamp: 2025-07-15T21:09:23.252Z
Learning: In Linux kernel configuration, when CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y is set, the ondemand governor is implicitly enabled by default, making the explicit CONFIG_CPU_FREQ_GOV_ONDEMAND=y line redundant. The make menuconfig tool automatically removes such redundant lines. This behavior applies to CPU frequency governor configurations in general - setting a default governor automatically enables that governor.
Learnt from: pyavitz
PR: #8388
File: config/boards/kickpik2b.conf:1-14
Timestamp: 2025-07-17T04:12:33.125Z
Learning: In the Armbian build system, board configuration files (*.conf) follow a project standard of not including shebang lines, even though they contain bash code and are sourced by the build system. This is an established Armbian convention that individual contributors are expected to follow, and changes to this standard would require broader project maintainer approval.
Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Learnt from: EvilOlaf
PR: #8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.
Learnt from: lanefu
PR: #8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT is a valid kernel configuration option in Linux kernel 6.12 and later versions, despite not being present in earlier versions like 6.9/6.10-rc.
Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:82-83
Timestamp: 2025-07-26T11:14:41.678Z
Learning: In Linux kernel 6.13 and later, CONFIG_ZBUD was deprecated and is scheduled for removal in kernel 6.15. The zbud compressed page allocator was found to consume more memory than alternatives like zsmalloc. Therefore, CONFIG_ZSWAP_ZPOOL_DEFAULT_ZBUD becomes obsolete in current kernels, and make defconfig will auto-correct by removing such deprecated options. This demonstrates how kernel defconfigs can be backwards compatible but not forward compatible.
Learnt from: lanefu
PR: #8377
File: config/kernel/linux-uefi-arm64-cloud.config:165-170
Timestamp: 2025-07-19T00:03:42.995Z
Learning: CONFIG_NETKIT was introduced in Linux kernel 4.14.330 (November 2023) and enables BPF-programmable network devices that can operate in Layer 3 or Layer 2 mode. It's a valid configuration option in modern kernels including 6.12.
Learnt from: pyavitz
PR: #8421
File: config/kernel/linux-sunxi64-edge.config:1058-1061
Timestamp: 2025-07-26T11:17:56.856Z
Learning: I2C_DESIGNWARE_SLAVE is a bool configuration option in Linux kernel Kconfig, not tristate. This means it can only be set to 'y' (enabled) or 'n' (disabled), never 'm' (module). When enabled, the slave functionality is compiled into the I2C_DESIGNWARE_CORE driver, regardless of whether the core driver is built-in or as a module.
config/sources/families/rockchip.conf (8)
Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Learnt from: EvilOlaf
PR: armbian/build#0
File: :0-0
Timestamp: 2025-07-21T04:12:02.439Z
Learning: In the Armbian build system, for recurring maintenance tasks like kernel version bumping, TODO comments should use generic version formats (e.g., "MAJOR.MINOR-rc1") rather than specific version numbers (e.g., "6.17-rc1") to avoid the need for frequent comment updates that would create unnecessary maintenance overhead.
Learnt from: EvilOlaf
PR: #8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.
Learnt from: Grippy98
PR: #8152
File: lib/functions/configuration/interactive.sh:209-266
Timestamp: 2025-05-05T12:35:07.143Z
Learning: For the interactive kernel selection in Armbian, KERNEL_MAJOR_MINOR and KERNEL_DESCRIPTION are parsed from family.conf but deliberately not set as environment variables to avoid potential interference with other parts of the build system.
Learnt from: The-going
PR: #8147
File: config/sources/families/include/sunxi64_common.inc:38-39
Timestamp: 2025-04-30T16:16:47.150Z
Learning: The Armbian build system references Linux kernel versions in the form "tag:v6.14.4" in the KERNELBRANCH variable, even when point release tags might not be directly visible in the upstream repository in the same form.
Learnt from: libiunc
PR: #8033
File: config/kernel/linux-starfive2-vendor.config:43-43
Timestamp: 2025-03-31T12:57:13.880Z
Learning: For StarFive2 platform kernel configurations, maintain alignment with vendor-provided configurations rather than modifying security settings like SECCOMP. This ensures hardware compatibility as intended by the manufacturer.
Learnt from: EvilOlaf
PR: #8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.
Learnt from: rpardini
PR: #8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
🧬 Code Graph Analysis (1)
config/sources/families/rockchip.conf (2)
config/sources/mainline-kernel.conf.sh (1)
mainline_kernel_decide_version__upstream_release_candidate_number(8-14)lib/functions/compilation/armbian-kernel.sh (1)
armbian_kernel_config__netkit(46-53)
🔇 Additional comments (2)
config/sources/families/rockchip.conf (1)
57-60: Confirm the follow-up switch from RC to the final 6.16 tag
KERNEL_MAJOR_MINOR="6.16"triggers themainline-kernel_decide_version__upstream_release_candidate_number()hook, which currently pinsKERNELBRANCHtotag:v6.16-rc7.
Unless this file (or the hook) is updated after the final 6.16 release, users will continue to receive the -rc kernel. Please plan a follow-up bump (or remove the hard-coded RC logic) so that stable images aren’t built on a release candidate.config/kernel/linux-rockchip-edge.config (1)
1129-1132: Switching SIMPLEDRM from built-in to module may drop early framebuffer output
CONFIG_DRM_SIMPLEDRM=mmeans the generic firmware-/DT-backed framebuffer is no longer available until modules load.
On boards without an early native DRM driver (or if the rootfs is on slow media), this can leave the screen blank during boot and hide kernel panics. Verify that:
- Rockchip DRM really probes early enough on every supported board.
- SimpleDRM was not previously relied on for splash/console.
If early output is still desired, consider keeping it built-in:
-CONFIG_DRM_SIMPLEDRM=m +CONFIG_DRM_SIMPLEDRM=y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and was boot tested. remaining problems were documented here. thank you for your work.
Description
Bump rockchip edge to kernel 6.16.
GitHub issue reference:
Jira reference number AR-2718
How Has This Been Tested?
Checklist:
Please delete options that are not relevant.