coolpi-genbook: Add Support for vendor branch

[andyshrk]

Description

The dts for vendor kernel has been merged .
Add vendor branch support for Cool Pi Genbook
And use mainline u-boot for vendor branch。

How Has This Been Tested?

Compiled with command：
./compile.sh build BOARD=coolpi-genbook BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED='browsers chat desktop_tools editors email internet multimedia office programming remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base DOWNLOAD_MIRROR=bfsu EXPERT=yes EXTRAWIFI=no KERNEL_CONFIGURE=no RELEASE=noble

flash the img to sdcard， insert the sdcard to a usb disk， insert usb disk to genbook，the Armbian system can boot from
usb disk。

Checklist:

• [✅ ] My code follows the style guidelines of this project
• [✅] I have performed a self-review of my own code
• [✅] I have commented my code, particularly in hard-to-understand areas
• [✅] My changes generate no new warnings
• [✅] Any dependent changes have been merged and published in downstream modules

[coderabbitai]

Walkthrough

The configuration for the CoolPi GenBook board was updated to change the KERNEL_TARGET value from "edge" to "edge,vendor". The function post_family_config_branch_edge__coolpi-genbook_use_mainline_uboot() was renamed to post_family_config__coolpi-genbook_use_mainline_uboot(). Inside this function, the BOOTBRANCH_BOARD value was updated from "tag:v2025.01" to "tag:v2025.04". Other settings, such as the U-Boot source repository, patch directory, target map, and disabling of certain post-processing functions, remain unchanged. Functions handling writing U-Boot binaries were not modified.

Possibly related PRs

• lubancat2: bump u-boot to v2025.04 #8122: Updates U-Boot version to v2025.04 and modifies board-specific post-family configuration functions similarly.
• radxa-zero3: bump mainline uboot #8071: Updates mainline U-Boot version from v2025.01 to v2025.04 and modifies board-specific mainline U-Boot configuration functions.
• orangepi-5-max: switch edge u-boot to mainline #8082: Modifies board-specific configuration files to switch from "edge" U-Boot to mainline U-Boot, including renaming configuration functions and updating variables.

Suggested labels

ready to merge

Suggested reviewers

• igorpecovnik

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aec7978 and 073eda5.

📒 Files selected for processing (1)

• config/boards/coolpi-genbook.csc (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• config/boards/coolpi-genbook.csc

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[EvilOlaf]

Um...why mainline uboot with vendor kernel? Doesn't edge use mainline uboot too? This looks confusing.

[andyshrk]

Um...why mainline uboot with vendor kernel? Doesn't edge use mainline uboot too? This looks confusing.

The main reason is that Coolpi's vendor u-boot has do heavily modifications. They even imported the cross-compiler toolchain into the u-boot repository. Moreover, due to some modifications to the memory layout in there vendor u-boot, it is impossible to start armbian. Based on my current tests, using the mainline to start both the vendor and the mainline branch works perfectly. Therefore, I will simply use a single u-boot to keep things simple.

[igorpecovnik]

Based on my current tests, using the mainline to start both the vendor and the mainline branch works perfectly.

OK, that is understandable.

Why two configs / functions with different u-boot tag? Won't one function config cover both? Seems like a lot of doubled code in the board config.

[andyshrk]

Based on my current tests, using the mainline to start both the vendor and the mainline branch works perfectly.

OK, that is understandable.

Why two configs / functions with different u-boot tag? Won't one function config cover both? Seems like a lot of doubled code in the board config.

Yes, they should use the same u-boot tag. It would be even better if the one function/hook could be used to achieve this. I just don't know how to write it yet. Will try....

[igorpecovnik]

Try from
post_family_config_branch_vendor__coolpi-genbook_use_mainline_uboot
to:
post_family_config__coolpi-genbook_use_mainline_uboot

[andyshrk]

Try from post_family_config_branch_vendor__coolpi-genbook_use_mainline_uboot to: post_family_config__coolpi-genbook_use_mainline_uboot

Yeah，it works， thanks。 I updated a new version now。