Sign APA repository with multiple keys at once

[igorpecovnik]

Sign with old and new key.

[coderabbitai]

Walkthrough

The GitHub Actions workflow for the "merge" job was updated to import two separate GPG keys from secrets and conditionally include them based on environment variables. A combined GPG_PARAMETERS string is constructed with flags and fingerprints of the imported keys for use in signing commands. The signing steps were modified to use this combined parameter string, enabling signing of InRelease and Release.gpg files with multiple keys. Other parts of the job, such as repository creation, committing, and pushing, remain unchanged. No changes were made to exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d66793b and 132f81b.

📒 Files selected for processing (1)

• .github/workflows/build.yml (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• .github/workflows/build.yml

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: amd64
• GitHub Check: armhf
• GitHub Check: arm64

✨ Finishing Touches

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch multiple

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/build.yml (2)

83-92: Build multi-key GPG parameters
The script concatenates --yes --armor with -u <fingerprint> flags for each imported key. Consider adding --batch --pinentry-mode loopback to the GPG_PARAMETERS string to suppress any interactive prompts in CI and ensure fully non-interactive signing.

---

102-109: Use combined GPG parameters for signing
The signing loop leverages the generated GPG_PARAMETERS for both clear-signed and detached signatures. As an alternative, you could reference the runtime variable directly ($GPG_PARAMETERS) instead of the expression syntax (${{ env.GPG_PARAMETERS }}) for clarity in the shell script.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9be6552 and aa1e246.

📒 Files selected for processing (1)

• .github/workflows/build.yml (3 hunks)

🔇 Additional comments (3)

.github/workflows/build.yml (3)

50-52: Define dual GPG key env variables
The PRIMARY_KEY and SECONDARY_KEY environment variables are correctly set from secrets for dual-key signing during the transition period.

---

71-76: Conditional import of the primary GPG key
This step properly uses if: env.PRIMARY_KEY != '' and the crazy-max/ghaction-import-gpg action to import the primary key only when provided.

---

77-82: Conditional import of the secondary GPG key
Likewise, the secondary key import is gated by if: env.SECONDARY_KEY != '' and correctly configured.

[leggewie]

Very well done, Igor. Thank you for taking care of this.