Make use of RUNTIMES_USE_LIBC to build libcxx #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of RUNTIMES_USE_LIBC CMake option to indicate which C library is used to build libcxx. This option was enabled in llvm/llvm-project#147956 instead of hardcoded check for corresponding C library header files.
voltur01
added a commit
to voltur01/arm-toolchain
that referenced
this pull request
Dec 3, 2025
Fix up for arm#623: RUNTIMES_USE_LIBC=llvm-libc has special handling in https://github.com/llvm/llvm-project/blob/8feb6762ba9fb83f8e13ef9486c3b743e1b5cfa7/runtimes/cmake/Modules/HandleLibC.cmake#L26 that breaks ATfE build by adding -nostdlibc option. Keep using the default system option for now, llvm-libc handling needs further investigation.
voltur01
added a commit
that referenced
this pull request
Dec 3, 2025
Fix up for #623: RUNTIMES_USE_LIBC=llvm-libc has special handling in https://github.com/llvm/llvm-project/blob/8feb6762ba9fb83f8e13ef9486c3b743e1b5cfa7/runtimes/cmake/Modules/HandleLibC.cmake#L26 that breaks ATfE build by adding -nostdlibc option. Keep using the default system option for now, llvm-libc handling needs further investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of RUNTIMES_USE_LIBC CMake option to indicate which C library is used to build libcxx.
This option was enabled in llvm/llvm-project#147956 instead of hardcoded check for corresponding C library header files.