Skip to content

Add command line options in About window - fixes #37 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

midwan
Copy link
Collaborator

@midwan midwan commented Nov 13, 2023

  • Extended the About window width to better fit the content
  • Added the command line options in the end of the Description

- Extended the About window width to better fit the content
- Added the command line options in the end of the Description
@CHerSun
Copy link

CHerSun commented Jan 9, 2025

-s / --seconds option is wrong both on readme and in your PR. It's -s:<seconds> or --seconds:<seconds>, not -s <seconds>. See #80. Hopefully both locations would be fixed some day.

@midwan
Copy link
Collaborator Author

midwan commented Jan 9, 2025

Oh, thanks for that. I'll update my PR, though I don't think it will ever get merged.
This project seems abandoned, unfortunately.

But I can keep my fork updated and do any further fixes there, including upgrading it to the latest .NET version.

@midwan
Copy link
Collaborator Author

midwan commented Jan 9, 2025

Hm, after doing some testing, what you mention doesn't seem to be the case. At least not when starting this from the debugger.

If we use -s:X where X is a valid int, the parameter is not parsed and ends up as zero.
If we use -s X instead, we get the value.

@midwan
Copy link
Collaborator Author

midwan commented Jan 9, 2025

Reverted my changes in the PR

@CHerSun
Copy link

CHerSun commented Jan 9, 2025

Fought with this in the compiled binary, until I found #80. Code might have that fixed already somewhere, sorry, my bad.

@CHerSun
Copy link

CHerSun commented Jan 9, 2025

But I can keep my fork updated and do any further fixes there, including upgrading it to the latest .NET version.

Would be cool, if you could upkeep the project with all those minor changes piling up. Especially if you can retarget scoop and chocolatey to your fork.

@midwan
Copy link
Collaborator Author

midwan commented Jan 9, 2025

I've updated mine to NET 9 already, fixed a few minor things here and there, and cherry-picked some of the suggested PRs here.

If there's enough interest, and if this repo is indeed abandoned (and not idle for some reason, which I fully respect), I could look into doing more, like chocolatey, winget etc.

@vinaykapadia
Copy link

Please do! I'm also interested in having a fork of this project that is actively maintained.

@cerebrate
Copy link
Member

cerebrate commented Jan 9, 2025

@midwan Actually, about that --

I've been meaning to get back to working on this project for literally years at this time, but other work in other areas keeps getting in the way - and, to be fair, it's no longer something I use for myself, so it tends to fall easily out of my attention - which isn't exactly fair to the user community. I think everyone would agree that it could use a maintainer who has the time and energy to pay attention to it.

So if you'd like to be that maintainer, I'd be happy to give you the relevant access to this repository, or, heck, even just transfer the repo over to you lock, stock, and barrel.

Interested?

@midwan
Copy link
Collaborator Author

midwan commented Jan 10, 2025

@cerebrate
Yes, I'm interested! :)

Let's discuss the details and find the best way forward. Can you drop me an e-mail? midwan at gmail dot com

Thank you!

@midwan midwan merged commit d46761a into arkane-systems:master Jan 13, 2025
@midwan midwan deleted the add-cmdline-options-in-about branch January 13, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants