Bump next from 13.5.6 to 14.2.12 #116
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [next](https://github.com/vercel/next.js) from 13.5.6 to 14.2.10. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v13.5.6...v14.2.10) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
We tried applying this earlier already (see #114) and merged it (it's unfortunate that CI is not set up to run on PRs in this repo, so we had to merge to see if it works) - but it fails the builds, see https://github.com/ethereum/solidity-website/actions/runs/10924194254/job/30322639405 - likely due to also requiring a bump in the node version. I haven't yet properly checked if the vulnerability conditions apply to our case and thus how urgent this is. |
|
@wackerow is this something you can help with / take care of or should we look into this? |
| @@ -1,7 +1,8 @@ | |||
| /** @type {import('next').NextConfig} */ | |||
| const nextConfig = { | |||
| reactStrictMode: true, | |||
| output: 'standalone', | |||
There was a problem hiding this comment.
Why was this standalone by default? Should we still keep such behavior? I guess we can always set it to export for the website, no?
r0qs
changed the title
|
Hey @wackerow could you take a look at this PR when you have some time? Mainly about this question here: #116 (comment) |
This PR updates Next.js from version 13.5.6 to 14.2.12.
It also updates the Node.js version in the deployment workflow from v16 to v18, as this is now the minimum version required by Next.js v14 (see: https://github.com/ethereum/solidity-website/actions/runs/10924194254/job/30322639405#step:7:10).
Due to breaking changes in the Next.js configuration (see: https://nextjs.org/docs/pages/building-your-application/deploying/static-exports#version-history), I replaced the use of
next export -o docs. If we still need the default output to bestandalone, some refactoring will be required to support conditional output based on different environments.