Unify http auth for http templates and input/output artifacts #14877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds support for various auth implementations to the HTTP Template.
Previously, HTTP authentication implementations were duplicated between HTTP templates and input/output artifacts, leading to code duplication and potential inconsistencies. This change consolidates the authentication logic into a shared module to improve maintainability and ensure consistent behavior across all HTTP operations.
Modifications
workflow/common/http_auth.go
module with unified HTTP authentication functionsApplyHTTPAuth()
function to apply authentication to HTTP requestsCreateHTTPClientWithAuth()
function to create authenticated HTTP clientsworkflow/artifacts/http/http.go
to use the new unified authentication functionsworkflow/executor/agent.go
to leverage the shared authentication modulepkg/apis/workflow/v1alpha1/http_types.go
with additional auth configuration fieldsVerification
Documentation
No documentation changes required as this is an internal refactoring that maintains existing API compatibility. The unified authentication approach is transparent to users and doesn't change how authentication is configured.