fix: handle escape chars in withParam/withItems. Fixes #13718 #14864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tzu-Ting <[email protected]>
Signed-off-by: Tzu-Ting <[email protected]>
tzing
force-pushed
the
fix/withparam-escape
branch
from
51a5ad0 to
e50be2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13718
Motivation
On using withParam/withItems on DAG/Steps, Argo Workflow mistakenly replace the
\nchars as\\nand it may break some tasks.Modifications
The operator used a JSON serialized string for building items. This casues some escape string got escaped again.
This PR use the the
GetStrValmethod to extract its original value.Verification
Covered in the test cases added in e50be2e
Documentation