fix: Fixes parameterized global artifacts resolution in exit handlers. Fixes #11610 #14860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes argoproj#11610 Signed-off-by: ItielOlenick <[email protected]>
…resolution-in-exit-handlers
ItielOlenick
changed the title
Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
…roj#14856) Signed-off-by: shuangkun <[email protected]> Co-authored-by: lons <[email protected]>
Signed-off-by: Nitin Bhojwani <[email protected]>
…Fixes argoproj#14671 (argoproj#14724) Signed-off-by: Darko Janjic <[email protected]> Signed-off-by: isubasinghe <[email protected]> Co-authored-by: isubasinghe <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]> Co-authored-by: lons <[email protected]>
…4854) Signed-off-by: shuangkun <[email protected]> Co-authored-by: lons <[email protected]>
) Signed-off-by: jmeridth <[email protected]>
…proj#14855) Signed-off-by: shuangkun <[email protected]> Co-authored-by: lons <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
argoproj#14908) Signed-off-by: shuangkun <[email protected]> Signed-off-by: Sebastien Dionne <[email protected]> Signed-off-by: Tianchu Zhao <[email protected]> Co-authored-by: shuangkun tian <[email protected]> Co-authored-by: lons <[email protected]> Co-authored-by: Tianchu Zhao <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
… (argoproj#14920) Signed-off-by: isubasinghe <[email protected]>
…rgoproj#14784) Signed-off-by: Darko Janjic <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Joibel <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
…roj#11898 (argoproj#14655) Signed-off-by: 민선 (minnie) <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: shota3506 <[email protected]>
… Fixes:argoproj#13948 (argoproj#14892) Signed-off-by: shuangkun <[email protected]>
…j#14610 (argoproj#14614) Signed-off-by: shuangkun <[email protected]>
Signed-off-by: AnonyScorpio <[email protected]>
…roj#14865) Signed-off-by: Joep Keijsers <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
…rgoproj#14909) Signed-off-by: Mason Malone <[email protected]>
Signed-off-by: Mason Malone <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
Signed-off-by: shota3506 <[email protected]>
…rgoproj#14927 (argoproj#14941) Signed-off-by: Mason Malone <[email protected]>
Signed-off-by: oninowang <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: shota3506 <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
…ge (argoproj#14943) Signed-off-by: shota3506 <[email protected]> Signed-off-by: Alan Clucas <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
Signed-off-by: wangxiaojian <[email protected]>
Signed-off-by: Alan Clucas <[email protected]>
Signed-off-by: shota3506 <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
Signed-off-by: puretension <[email protected]>
Signed-off-by: Andrey Kuznetsov <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
…proj#14879) Signed-off-by: Eduardo Rodrigues <[email protected]> Co-authored-by: Alan Clucas <[email protected]>
…Fixes argoproj#11610 Signed-off-by: ItielOlenick <[email protected]>
ItielOlenick
requested review from
Joibel,
sarabala1979 and
terrytangyuan
as code owners
…n-in-exit-handlers Signed-off-by: ItielOlenick <[email protected]>
Signed-off-by: ItielOlenick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11610
Motivation
Workflows with parameterized global artifact names (e.g.,
globalName: output-result-{{inputs.parameters.variable}}) fail validation in exit handlers after v3.4.6 witherrors like "failed to resolve {{workflow.outputs.artifacts.output-result-car}}". This worked correctly in v3.4.5 and earlier.
Modifications
anyWorkflowOutputArtifactMagicValuewhen parameterized global artifacts existVerification
Documentation
No documentation changes needed - this restores existing functionality that was inadvertently broken.