Skip to content

fix(argo-cd): correct typo 'Addtional' to 'Additional' in values.yaml #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

fix(argo-cd): correct typo 'Addtional' to 'Additional' in values.yaml #3403

merged 2 commits into from
Jul 28, 2025
+5 −5

Conversation

in-jun
Copy link
Contributor

@in-jun in-jun commented Jul 28, 2025 •
edited
Loading

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

Fix typo: "Addtional" → "Additional" in values.yaml line 38

@yu-croco
Copy link
Collaborator

Hi @in-jun , thank you for your PR.

I have updated the documentation according to documentation

can you please update doc by running ./scripts/helm-docs.sh ? Then the typo in charts/argo-cd/README.md will be fixed.
image

@in-jun
docs(argo-cd): update README.md to fix typo 'Addtional' to 'Additional'
bbfd5e6 
Generated by running ./scripts/helm-docs.sh as requested in PR review.

Signed-off-by: in-jun <[email protected]>
@in-jun
Copy link
Contributor Author

in-jun commented Jul 28, 2025 •
edited
Loading

Thanks @yu-croco! I've run ./scripts/helm-docs.sh and updated the README.md as requested.

yu-croco
yu-croco approved these changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@mbevc1 mbevc1 merged commit f8cf03f into argoproj:main Jul 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@in-jun @yu-croco @mbevc1