feat: Expose Prometheus metrics. Closes #204 #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Feb 5, 2021
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
reviewed
Feb 9, 2021
eventsources/eventing.go
Outdated
| continue | ||
| } | ||
| wg.Add(1) | ||
| e.metrics.IncRunningServices(server.GetEventSourceName()) |
Contributor
There was a problem hiding this comment.
move one line down so code change cannot create regression?
alexec
reviewed
Feb 9, 2021
docs/metrics.md
Outdated
| ### EventSource | ||
| - `event_service_running_total` - How many configured events in the EventSource |
Contributor
There was a problem hiding this comment.
can I ask for a section state which metrics is which Golden Metric?
Signed-off-by: Derek Wang <[email protected]>
alexec
reviewed
Feb 11, 2021
docs/metrics.md
Outdated
| ### EventSource | ||
| - `event_service_running_total` - How many configured events in the EventSource |
Contributor
There was a problem hiding this comment.
in Argo Workflow the Prometheus HELP contains deep-links to the docs, you could do this same here, allowing you to change the help with a release
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
reviewed
Feb 19, 2021
docs/metrics.md
Outdated
|
|
||
| - Saturation | ||
|
|
||
| - TBD. |
Contributor
There was a problem hiding this comment.
this is probably covered by out of the box Kubernetes metrics such as CPU or memory (RSS)
docs/metrics.md
Outdated
|
|
||
| - Latency | ||
|
|
||
| - TBD. |
Contributor
There was a problem hiding this comment.
"The time it takes to service a request. "
What is a request in events?
- Event Source - the time from getting event to send message to EventBus?
- EventBus - the time from receive a NATS message to dispatching it?
- Sensor - the time from receiving event to getting trigger finishing?
Member
Author
There was a problem hiding this comment.
- Added the latency for Sensor triggering actions.
- Event Source latency would be added in future PRs as it requires to make code change to every event source implementation.
- EventBus latency needs further investigation - we could not calculate it from the clients side (when eventsource sends it, and when sensor receives it), but should look into if NATS exposes this kind of metrics, I haven't seen it so far, need more research.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
alexec
approved these changes
Feb 25, 2021
|
|
||
| > v1.3 and after | ||
| ## User Metrics |
Contributor
There was a problem hiding this comment.
"system" or "default metrics"?
| #### argo_events_event_processing_duration_milliseconds | ||
| Event processing duration (from getting the event to send it to EventBus) in | ||
| milliseconds - TBD. |
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* feat: Expose Prometheus metrics. Closes argoproj#204 Signed-off-by: Derek Wang <[email protected]>
This was referenced Mar 26, 2025
This was referenced May 10, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
Closes #204
Checklist: