Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

Include SHA of test merge commit in PR generator for GitHub #623

@purajit

Description

@purajit

Component: Pull Request Generator

Request: Currently, when using the PR Generator with GitHub, we are provided with the head_sha. Additionally being provided with merge_commit_sha would be extremely useful.

Motivation: The default behavior of a lot of widely-used GHAs, such as actions/checkout and docker/metadata-action, is to use the test merge commit sha rather than the head sha. Providing this value would mean users have a way of working with PR generator without having to override this behavior throughout their stack, and seeing predicatable values being propagated everywhere.

I'm unfamiliar with GitLab and Gitea but I think based on some quick searching that they too create test merge commits, but at least for GH, it seems like it would require a change

Other links:
MergeCommitSHA in the GitHub client
Argo docs for template and params
Information about test merge commit SHA and how it changes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions