Skip to content

fix(acdcs): sort status.applicationsSelected (#408) #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

crenshaw-dev
Copy link
Contributor

@crenshaw-dev crenshaw-dev commented Jul 11, 2025

Closes #408

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.77%. Comparing base (5cb0026) to head (9ac8f67).

Files with missing lines Patch % Lines
...ternal/controller/argocdcommitstatus_controller.go 76.66% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   48.19%   48.77%   +0.58%     
==========================================
  Files          33       33              
  Lines        3457     3477      +20     
==========================================
+ Hits         1666     1696      +30     
+ Misses       1580     1573       -7     
+ Partials      211      208       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev marked this pull request as ready for review July 14, 2025 14:22
@zachaller zachaller merged commit 2f99533 into argoproj-labs:main Jul 15, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCDCommitStatus status field should sort applicationsSelected by environment, then namespace, then name
3 participants