-
Notifications
You must be signed in to change notification settings - Fork 304
feat: fix force-update for zero-replica deployments by reading image tags from spec #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
==========================================
+ Coverage 63.05% 63.13% +0.07%
==========================================
Files 23 23
Lines 3140 3190 +50
==========================================
+ Hits 1980 2014 +34
- Misses 1050 1064 +14
- Partials 110 112 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e71b77b
to
6e731a7
Compare
case ApplicationTypeHelm: | ||
if source.Helm != nil && source.Helm.Parameters != nil { | ||
for _, param := range source.Helm.Parameters { | ||
if param.Name == "image.tag" || param.Name == "image.version" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The helm parameter names are not fixed and can vary, such as my.tag
, my.version
. How do we handle such different param names used to identify tag or version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengfang
you're right that Helm parameter names can vary. i'm thinking we could implement pattern matching using regex to detect different tag parameter naming conventions (e.g., *.tag
, *.version
, *.imageTag
).what do you think about this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using regex patterns sounds good. It should catch the majority of use cases. We should also document this limitation that when uncommon helm params are used along with 0-replica deployment and force-update, this issue can still occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chengfang
Thank you so much for your comment. I will handle this
6e731a7
to
4ea8ebe
Compare
4ea8ebe
to
983234f
Compare
…tags from spec Signed-off-by: chansuke <[email protected]>
983234f
to
4d7ded9
Compare
Closes #829
Resolves continuous update attempts for deployments with 0 replicas when
force-update=true
is set