AC-Dimmer Power lookup table #17177
Merged
AC-Dimmer Power lookup table #17177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Power on AC-Dimmer is based on integral over the sinus. Implement mapping table to get a more linear power behavior.
change to linear power distribution on PWM
s-hadinger
reviewed
Nov 24, 2022
| { 99, 936 }, | ||
| { 100, 1000 }, | ||
| { 0xFFFF, 0xFFFF } // fail-safe if out of range | ||
| { 0xFFFF, 0xFFFF } // fail-safe if out of range |
Collaborator
There was a problem hiding this comment.
You don't need to put it twice
Contributor
Author
There was a problem hiding this comment.
this was a copy&paste issue.....
Collaborator
|
Nice! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
AC-Dimmer was not linear on power because of the behavior AC-current to calculate the power through the integral over SINUS. Lookup table fix the linearity issue.
Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass