enhance(server): refactor and simplify `useContentEncoding` plugin #2229

ardatan · 2025-03-26T00:49:52Z

No description provided.

coderabbitai · 2025-03-26T00:50:00Z

📝 Walkthrough

Summary by CodeRabbit

Refactor
- Enhanced server content encoding processing, streamlining request and response handling for improved efficiency.
- Simplified underlying logic by eliminating redundant operations.

Walkthrough

This pull request introduces a new entry in the .changeset/mean-ties-report.md file to document a patch for the @whatwg-node/server package, specifically highlighting the simplification of the useContentEncoding plugin. The changes involve the removal of unused imports and helper functions, as well as a refactoring of the logic for handling content encoding in requests and responses.

Changes

File(s)	Change Summary
`.changeset/mean-ties-report.md`	Added a new entry documenting a patch for the `@whatwg-node/server` package that highlights the simplification of the `useContentEncoding` plugin.
`packages/server/src/plugins/useContent...`	Simplified the `useContentEncoding` function by removing unused imports and helper functions. The logic for processing the `content-encoding` header has been streamlined along with response handling, reducing redundant checks and operations.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant Plugin as useContentEncoding
    Client->>Server: Send request with "content-encoding" header
    Server->>Plugin: Invoke request handling
    Plugin-->>Server: Process and simplify content decoding
    Server->>Plugin: Handle response (check "accept-encoding" header)
    Plugin-->>Server: Return processed response
    Server->>Client: Send final response

Poem

I'm a rabbit hopping through the code,
Cleaning up streams on my bumpy road.
Unused imports left in the dust,
Simplified logic—clean and robust!
With ears up high, I cheer these changes! 🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bedb70a and 6dd5558.

📒 Files selected for processing (1)

packages/server/src/plugins/useContentEncoding.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/server/src/plugins/useContentEncoding.ts

⏰ Context from checks skipped due to timeout of 90000ms (10)

GitHub Check: unit / node 23
GitHub Check: unit / node 22
GitHub Check: unit / deno
GitHub Check: unit / bun
GitHub Check: server (undici)
GitHub Check: unit / node 20
GitHub Check: unit / node 18
GitHub Check: e2e / azure-function
GitHub Check: node-fetch (noConsumeBody)
GitHub Check: e2e / aws-lambda

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-26T00:51:44Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@whatwg-node/server`	`0.10.4-alpha-20250326010746-6dd55585a4976f4d80b11704acd73246aaff31f6`	npm ↗︎ unpkg ↗︎

github-actions · 2025-03-26T00:52:35Z

✅ `@benchmarks/server` results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 227248      ✗ 0     
     data_received..................: 23 MB   761 kB/s
     data_sent......................: 9.1 MB  303 kB/s
     http_req_blocked...............: avg=1.52µs   min=952ns    med=1.29µs   max=208.17µs p(90)=2.01µs   p(95)=2.19µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=130.23µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=200.33µs min=145.96µs med=190.35µs max=9.75ms   p(90)=215.26µs p(95)=224.94µs
       { expected_response:true }...: avg=200.33µs min=145.96µs med=190.35µs max=9.75ms   p(90)=215.26µs p(95)=224.94µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 113624
     http_req_receiving.............: avg=26.07µs  min=13.62µs  med=24.54µs  max=2.7ms    p(90)=31.75µs  p(95)=34.11µs 
     http_req_sending...............: avg=6.68µs   min=4.16µs   med=5.93µs   max=2.36ms   p(90)=8.36µs   p(95)=9.28µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=167.56µs min=119.09µs med=157.85µs max=9.68ms   p(90)=179.87µs p(95)=188.86µs
     http_reqs......................: 113624  3787.330803/s
     iteration_duration.............: avg=259.44µs min=195.51µs med=248.4µs  max=9.87ms   p(90)=276.7µs  p(95)=288.84µs
     iterations.....................: 113624  3787.330803/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-03-26T00:53:01Z

✅ `@benchmarks/node-fetch` results (consumeBody)

   ✓ active_handles.................: avg=140.132553 min=18      med=141     max=187     p(90)=161     p(95)=166    
     data_received..................: 20 MB  669 kB/s
     data_sent......................: 13 MB  429 kB/s
     http_req_blocked...............: avg=3.34µs     min=661ns   med=1.3µs   max=6ms     p(90)=2.13µs  p(95)=2.42µs 
     http_req_connecting............: avg=1.4µs      min=0s      med=0s      max=4.53ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.79ms    min=4.42ms  med=22.21ms max=1.01s   p(90)=28.62ms p(95)=30.26ms
       { expected_response:true }...: avg=22.79ms    min=4.42ms  med=22.21ms max=1.01s   p(90)=28.62ms p(95)=30.26ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 131220
     http_req_receiving.............: avg=34.52µs    min=10.1µs  med=25.52µs max=13.09ms p(90)=40.22µs p(95)=47.01µs
     http_req_sending...............: avg=11.26µs    min=3.66µs  med=6.63µs  max=10.64ms p(90)=10.54µs p(95)=14.73µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22.74ms    min=4.37ms  med=22.17ms max=1.01s   p(90)=28.57ms p(95)=30.2ms 
     http_reqs......................: 131220 4373.580649/s
     iteration_duration.............: avg=45.69ms    min=13.72ms med=44.34ms max=1.03s   p(90)=48.8ms  p(95)=54.22ms
     iterations.....................: 65574  2185.59044/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100

github-actions · 2025-03-26T00:53:20Z

✅ `@benchmarks/node-fetch` results (noConsumeBody)

   ✓ active_handles.................: avg=140.232224 min=30      med=141     max=192      p(90)=161     p(95)=165    
     data_received..................: 22 MB  730 kB/s
     data_sent......................: 14 MB  473 kB/s
     http_req_blocked...............: avg=3.94µs     min=622ns   med=1.41µs  max=10.87ms  p(90)=2.08µs  p(95)=2.37µs 
     http_req_connecting............: avg=1.97µs     min=0s      med=0s      max=5.32ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.88ms    min=7.07ms  med=20.3ms  max=965.48ms p(90)=26.12ms p(95)=28.03ms
       { expected_response:true }...: avg=20.88ms    min=7.07ms  med=20.3ms  max=965.48ms p(90)=26.12ms p(95)=28.03ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 143166
     http_req_receiving.............: avg=33.57µs    min=9.38µs  med=23.99µs max=20.78ms  p(90)=39.28µs p(95)=46.26µs
     http_req_sending...............: avg=11.18µs    min=3.34µs  med=6.73µs  max=11.38ms  p(90)=10.19µs p(95)=14.29µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.84ms    min=7.03ms  med=20.26ms max=965.39ms p(90)=26.08ms p(95)=27.96ms
     http_reqs......................: 143166 4771.452537/s
     iteration_duration.............: avg=41.88ms    min=19.47ms med=40.49ms max=987.34ms p(90)=46.15ms p(95)=50.9ms 
     iterations.....................: 71556  2384.826409/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100

github-actions · 2025-03-26T00:53:23Z

✅ `@benchmarks/server` results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 285032      ✗ 0     
     data_received..................: 28 MB   936 kB/s
     data_sent......................: 11 MB   380 kB/s
     http_req_blocked...............: avg=1.39µs   min=842ns    med=1.18µs   max=202.31µs p(90)=1.87µs   p(95)=2.02µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=124.1µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=147.2µs  min=95.4µs   med=142.57µs max=5.92ms   p(90)=163.64µs p(95)=170.92µs
       { expected_response:true }...: avg=147.2µs  min=95.4µs   med=142.57µs max=5.92ms   p(90)=163.64µs p(95)=170.92µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 142516
     http_req_receiving.............: avg=24.2µs   min=12.62µs  med=23.11µs  max=2.32ms   p(90)=29.16µs  p(95)=32µs    
     http_req_sending...............: avg=6.43µs   min=4.05µs   med=5.58µs   max=341.46µs p(90)=8.22µs   p(95)=8.96µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=116.56µs min=69.1µs   med=111.78µs max=5.87ms   p(90)=130.38µs p(95)=136.68µs
     http_reqs......................: 142516  4750.379469/s
     iteration_duration.............: avg=205.93µs min=147.24µs med=200.57µs max=13.08ms  p(90)=225.28µs p(95)=234.63µs
     iterations.....................: 142516  4750.379469/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-03-26T00:53:43Z

✅ `@benchmarks/server` results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 210054      ✗ 0     
     data_received..................: 21 MB   704 kB/s
     data_sent......................: 8.4 MB  280 kB/s
     http_req_blocked...............: avg=1.51µs   min=911ns    med=1.28µs   max=214.34µs p(90)=2.01µs   p(95)=2.2µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=156.65µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=220.53µs min=163.35µs med=206.77µs max=65.33ms  p(90)=234.88µs p(95)=246.33µs
       { expected_response:true }...: avg=220.53µs min=163.35µs med=206.77µs max=65.33ms  p(90)=234.88µs p(95)=246.33µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 105027
     http_req_receiving.............: avg=26.5µs   min=14.17µs  med=24.65µs  max=3.08ms   p(90)=32.12µs  p(95)=34.96µs 
     http_req_sending...............: avg=6.84µs   min=4.15µs   med=6.19µs   max=1.13ms   p(90)=8.59µs   p(95)=9.78µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=187.17µs min=135.56µs med=173.92µs max=65.23ms  p(90)=198.47µs p(95)=208.66µs
     http_reqs......................: 105027  3500.750473/s
     iteration_duration.............: avg=280.94µs min=209.59µs med=266.01µs max=65.5ms   p(90)=298.64µs p(95)=313.04µs
     iterations.....................: 105027  3500.750473/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

enhance(server): refactor and simplify useContentEncoding plugin

bedb70a

identity

6dd5558

ardatan merged commit 9655941 into master Apr 8, 2025
25 checks passed

github-actions bot mentioned this pull request Apr 8, 2025

Upcoming Release Changes #2279

Merged

ardatan deleted the refactor-content-encoding branch May 12, 2025 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

enhance(server): refactor and simplify `useContentEncoding` plugin #2229

enhance(server): refactor and simplify `useContentEncoding` plugin #2229

Uh oh!

ardatan commented Mar 26, 2025

Uh oh!

coderabbitai bot commented Mar 26, 2025 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enhance(server): refactor and simplify useContentEncoding plugin #2229

enhance(server): refactor and simplify useContentEncoding plugin #2229

Uh oh!

Conversation

ardatan commented Mar 26, 2025

Uh oh!

coderabbitai bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (alpha)

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ @benchmarks/server results (native)

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ @benchmarks/node-fetch results (consumeBody)

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ @benchmarks/node-fetch results (noConsumeBody)

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ @benchmarks/server results (ponyfill)

Uh oh!

github-actions bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ @benchmarks/server results (undici)

Uh oh!

Uh oh!

Uh oh!

enhance(server): refactor and simplify `useContentEncoding` plugin #2229

enhance(server): refactor and simplify `useContentEncoding` plugin #2229

coderabbitai bot commented Mar 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 26, 2025 •

edited

Loading

🚀 Snapshot Release (`alpha`)

github-actions bot commented Mar 26, 2025 •

edited

Loading

✅ `@benchmarks/server` results (native)

github-actions bot commented Mar 26, 2025 •

edited

Loading

✅ `@benchmarks/node-fetch` results (consumeBody)

github-actions bot commented Mar 26, 2025 •

edited

Loading

✅ `@benchmarks/node-fetch` results (noConsumeBody)

github-actions bot commented Mar 26, 2025 •

edited

Loading

✅ `@benchmarks/server` results (ponyfill)

github-actions bot commented Mar 26, 2025 •

edited

Loading

✅ `@benchmarks/server` results (undici)