Fix type inference for ThenInclude with casting. #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
approved these changes
Apr 23, 2025
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Jul 29, 2025
This was referenced Oct 1, 2025
This was referenced Oct 9, 2025
Bump Ardalis.Specification.EntityFrameworkCore from 7.0.0 to 9.3.1
mohamed-aadhil/eShopOnWeb_Clone#4
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463
There is an ongoing inconsistency in EF (described in the related issue). For now, we won't infer the previous property type from LambdaExpression, we'll keep it as a state in
IncludeExpressionInfo.The constructors of the
IncludeExpressionInfoare modified, so that might be a breaking change for anyone using it directly.