-
Notifications
You must be signed in to change notification settings - Fork 126
Fix Issue with Serializing Type When Using System.Text.Json #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
approved these changes
Oct 6, 2023
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This was referenced Sep 3, 2025
This was referenced Sep 19, 2025
This was referenced Sep 26, 2025
This was referenced Oct 3, 2025
This was referenced Oct 10, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Fixes #91
Fixes issue with lack of support for serialization of
Typewhen usingSystem.Text.Json's serializer by removing the property from the exported json altogether. Unit tests show output of serialization for reference.Pros:
Cons:
System.Text.Jsonto coreArdalis.Resultfor .NET Standard users. This is already a "baked in" dependency in .NET 7 version.https://www.nuget.org/packages/System.Text.Json/7.0.3#supportedframeworks-body-tab
Did you add tests?
If no, why not?
N/A