Skip to content

Conversation

amal-stack
Copy link
Contributor

No description provided.

@amal-stack amal-stack changed the title Update to dotnet 7.0 Upgrade to dotnet 7.0 Jun 27, 2023
@ardalis
Copy link
Owner

ardalis commented Jun 27, 2023

If we update to net7 that will make it tough for older projects to use. Is there anything that requires net7?

@amal-stack
Copy link
Contributor Author

@ardalis I tried upgrading because I noticed the CI builds have been failing lately due to an error in the ReferenceAssemblyAnnotator library:
Build Errors
It is an open issue in the library that it breaks on projects with multiple framework targets.
In my fork, the build succeeded when I upgraded to .NET 7. (This might also be due to the fact that build.yml uses dotnet 7 to build the project, not quite sure):
Commits
Notice the top two commits where the build started failing when I reverted to .NET 6.

@ardalis
Copy link
Owner

ardalis commented Jul 31, 2023

Weird, thanks. Looking into it.

@ardalis
Copy link
Owner

ardalis commented Jul 31, 2023

Since we still have netstandard targeting hopefully this should be fine.

@ardalis ardalis merged commit 322d1fa into ardalis:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants