Skip to content

Add tests removed due to bug in previous xunit versions #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Add tests removed due to bug in previous xunit versions #276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03f73b9
Add tests removed due to bug in previous xunit versions
joaonunomota Jun 1, 2023
c3b8df4
Merge branch 'main' into add-old-xunit-tests
ardalis Jun 23, 2023
208fee2
Merge branch 'main' into add-old-xunit-tests
ardalis Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/GuardClauses.UnitTests/GuardAgainstOutOfRangeForInvalidInput.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,14 @@ public async Task ExceptionParamNameMatchesExpectedAsync(string expectedParamNam
Assert.Equal(expectedParamName, exception.ParamName);
}

// TODO: Test decimal types outside of ClassData
// See: https://github.com/xunit/xunit/issues/2298
public class CorrectClassData : IEnumerable<object[]>
{
public IEnumerator<object[]> GetEnumerator()
{
yield return new object[] { 20, (Func<int, bool>)((x) => x > 10) };
yield return new object[] { DateAndTime.Now, (Func<DateTime, bool>)((x) => x > DateTime.MinValue) };
yield return new object[] { 20.0f, (Func<float, bool>)((x) => x > 10.0f) };
//yield return new object[] { 20.0m, (Func<decimal, bool>)((x) => x > 10.0m) };
yield return new object[] { 20.0m, (Func<decimal, bool>)((x) => x > 10.0m) };
yield return new object[] { 20.0, (Func<double, bool>)((x) => x > 10.0) };
yield return new object[] { long.MaxValue, (Func<long, bool>)((x) => x > 1) };
yield return new object[] { short.MaxValue, (Func<short, bool>)((x) => x > 1) };
Expand All @@ -125,7 +123,7 @@ public IEnumerator<object[]> GetEnumerator()
yield return new object[] { 20, (Func<int, Task<bool>>)((x) => Task.FromResult(x > 10)) };
yield return new object[] { DateAndTime.Now, (Func<DateTime, Task<bool>>)((x) => Task.FromResult(x > DateTime.MinValue)) };
yield return new object[] { 20.0f, (Func<float, Task<bool>>)((x) => Task.FromResult(x > 10.0f)) };
//yield return new object[] { 20.0m, (Func<decimal, Task<bool>>)((x) => Task.FromResult(x > 10.0m)) };
yield return new object[] { 20.0m, (Func<decimal, Task<bool>>)((x) => Task.FromResult(x > 10.0m)) };
yield return new object[] { 20.0, (Func<double, Task<bool>>)((x) => Task.FromResult(x > 10.0)) };
yield return new object[] { long.MaxValue, (Func<long, Task<bool>>)((x) => Task.FromResult(x > 1)) };
yield return new object[] { short.MaxValue, (Func<short, Task<bool>>)((x) => Task.FromResult(x > 1)) };
Expand All @@ -141,7 +139,7 @@ public IEnumerator<object[]> GetEnumerator()
yield return new object[] { 20, (Func<int, bool>)((x) => x < 10) };
yield return new object[] { DateAndTime.Now, (Func<DateTime, bool>)((x) => x > DateTime.MaxValue) };
yield return new object[] { 20.0f, (Func<float, bool>)((x) => x > 30.0f) };
//yield return new object[] { 20.0m, (Func<decimal, bool>)((x) => x > 30.0m) };
yield return new object[] { 20.0m, (Func<decimal, bool>)((x) => x > 30.0m) };
yield return new object[] { 20.0, (Func<double, bool>)((x) => x > 30.0) };
yield return new object[] { long.MaxValue, (Func<long, bool>)((x) => x < 1) };
yield return new object[] { short.MaxValue, (Func<short, bool>)((x) => x < 1) };
Expand All @@ -158,7 +156,7 @@ public IEnumerator<object[]> GetEnumerator()
yield return new object[] { 20, (Func<int, Task<bool>>)((x) => Task.FromResult(x < 10)) };
yield return new object[] { DateAndTime.Now, (Func<DateTime, Task<bool>>)((x) => Task.FromResult(x > DateTime.MaxValue)) };
yield return new object[] { 20.0f, (Func<float, Task<bool>>)((x) => Task.FromResult(x > 30.0f)) };
//yield return new object[] { 20.0m, (Func<decimal, bool>)((x) => x > 30.0m)) };
yield return new object[] { 20.0m, (Func<decimal, Task<bool>>)((x) => Task.FromResult(x > 30.0m)) };
yield return new object[] { 20.0, (Func<double, Task<bool>>)((x) => Task.FromResult(x > 30.0)) };
yield return new object[] { long.MaxValue, (Func<long, Task<bool>>)((x) => Task.FromResult(x < 1)) };
yield return new object[] { short.MaxValue, (Func<short, Task<bool>>)((x) => Task.FromResult(x < 1)) };
Expand Down