chore(az.sb): remove 'azure...' prefix in handlers/context #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnmoreels
added
enhancement
✅ Deploy Preview for arcus-messaging canceled.
|
stijnmoreels
commented
Aug 26, 2025
| /// <param name="entityType">The type of Azure Service bus entity that the <paramref name="eventArgs"/> receives from.</param> | ||
| /// <param name="eventArgs">The Azure Service bus event arguments upon receiving the message.</param> | ||
| /// <exception cref="ArgumentNullException">Thrown when one of the parameters is <c>null</c>.</exception> | ||
| public static AzureServiceBusMessageContext Create( |
There was a problem hiding this comment.
note: we haven't released the session-aware pump yet, so we can safely move it again here.
stijnmoreels
commented
Aug 26, 2025
src/Arcus.Messaging.Abstractions.ServiceBus/MessageHandling/AzureServiceBusMessageRouter.cs
Outdated
Show resolved
Hide resolved
…ureServiceBusMessageRouter.cs
stijnmoreels
commented
Aug 26, 2025
src/Arcus.Messaging.Abstractions.ServiceBus/MessageHandling/AzureServiceBusMessageRouter.cs
Outdated
Show resolved
Hide resolved
|
Maybe the more responsible approach would be to move this enhancement to v4.0, as there are already a lot of changes happening on v3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more dev-friendly approach that removes the
Azure...prefix noise from the handlers and message context, and places them in theArcus.Messagingnamespace.