Skip to content
This repository was archived by the owner on Sep 10, 2024. It is now read-only.

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels
Copy link
Member Author

stijnmoreels commented Mar 9, 2020

The build was not failed bc of this PR: https://dev.azure.com/codit/Arcus/_build/results?buildId=42188&view=logs&j=6f530bc7-0339-5c23-f0b1-5c642f3efaa5&t=dd031c7c-0a68-5383-196c-bc5d73ab51cf
Again something to do with updated Azure resources? @tomkerkhove ?

I'll update to EventGrid 3.0.0 in the meantime on this PR.

@stijnmoreels
Copy link
Member Author

Waiting till arcus-azure/arcus.messaging#79, logging could help pinpoint the issue.

<PackageReference Include="Arcus.Messaging.Pumps.ServiceBus" Version="0.1.0-preview-2" />
<PackageReference Include="Microsoft.Azure.EventGrid" Version="3.2.0" />
<PackageReference Include="Arcus.EventGrid" Version="3.0.0" />
<PackageReference Include="Arcus.Messaging.Pumps.ServiceBus" Version="20200312.0.0-PR-81" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to ship a new preview version instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we could do that. Then we can remove the MyGet sources from the project files too.

</ItemGroup>

<PropertyGroup>
<RestoreSources>$(RestoreSources);https://api.nuget.org/v3/index.json;https://www.myget.org/F/arcus/api/v3/index.json</RestoreSources>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this, no? But can't hurt thought.

@stijnmoreels
Copy link
Member Author

Released, waiting to be indexed by NuGet before I push...

@stijnmoreels stijnmoreels merged commit 752bf4a into master Mar 12, 2020
@tomkerkhove tomkerkhove deleted the chore/build-variables branch March 12, 2020 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants