-
Notifications
You must be signed in to change notification settings - Fork 7
Chore - move build variables to variable template #32
Conversation
The build was not failed bc of this PR: https://dev.azure.com/codit/Arcus/_build/results?buildId=42188&view=logs&j=6f530bc7-0339-5c23-f0b1-5c642f3efaa5&t=dd031c7c-0a68-5383-196c-bc5d73ab51cf I'll update to EventGrid 3.0.0 in the meantime on this PR. |
Waiting till arcus-azure/arcus.messaging#79, logging could help pinpoint the issue. |
<PackageReference Include="Arcus.Messaging.Pumps.ServiceBus" Version="0.1.0-preview-2" /> | ||
<PackageReference Include="Microsoft.Azure.EventGrid" Version="3.2.0" /> | ||
<PackageReference Include="Arcus.EventGrid" Version="3.0.0" /> | ||
<PackageReference Include="Arcus.Messaging.Pumps.ServiceBus" Version="20200312.0.0-PR-81" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to ship a new preview version instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we could do that. Then we can remove the MyGet sources from the project files too.
</ItemGroup> | ||
|
||
<PropertyGroup> | ||
<RestoreSources>$(RestoreSources);https://api.nuget.org/v3/index.json;https://www.myget.org/F/arcus/api/v3/index.json</RestoreSources> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this, no? But can't hurt thought.
Released, waiting to be indexed by NuGet before I push... |
Relates to arcus-azure/arcus#46