This repository was archived by the owner on Sep 10, 2024. It is now read-only.
fix: add default event uri to client expired background job #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-background-jobs canceled.
|
|
@pim-simons , I added a default event URI |
stijnmoreels
commented
May 11, 2022
src/Arcus.BackgroundJobs.AzureActiveDirectory/Extensions/IServiceCollectionExtensions.cs
Show resolved
Hide resolved
pim-simons
approved these changes
May 12, 2022
There was a problem hiding this comment.
Seems like a lot of improvements to me, great work @stijnmoreels 🥇
Ok, awesome! 😄 Glad you like it, and thx for the medal 😉 . |
@stijnmoreels after all his PR's 😉 |
|
fgheysels
reviewed
May 13, 2022
src/Arcus.BackgroundJobs.AzureActiveDirectory/ClientSecretExpirationJob.cs
Show resolved
Hide resolved
src/Arcus.BackgroundJobs.AzureActiveDirectory/ClientSecretExpirationJob.cs
Outdated
Show resolved
Hide resolved
fgheysels
approved these changes
May 16, 2022
…ob' of https://github.com/stijnmoreels/arcus.backgroundjobs into fix/add-default-event-uri-to-client-expired-backgroundjob
stijnmoreels
deleted the
fix/add-default-event-uri-to-client-expired-backgroundjob
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default value to the event URI added to the created CloudEvent so that a default-initialized background job without any options is still valid.
This PR also rewrites the logged telemetry event with a more clear structure.
Closes #137