Skip to content

feat: bigint literals without as const #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: bigint literals without as const #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b69471
feat: bigint literals without as const
paul-soporan Nov 21, 2020
27884cc
fix: tsconfig target issues
paul-soporan Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sources/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export function isLiteral(expected: null): StrictValidator<unknown, null>;
export function isLiteral(expected: true): StrictValidator<unknown, true>;
export function isLiteral(expected: false): StrictValidator<unknown, false>;
export function isLiteral<T extends number>(expected: T): StrictValidator<unknown, T>;
export function isLiteral<T extends bigint>(expected: T): StrictValidator<unknown, T>;
export function isLiteral<T extends string>(expected: T): StrictValidator<unknown, T>;
export function isLiteral<T>(expected: T): StrictValidator<unknown, T>;
export function isLiteral<T>(expected: T) {
Expand Down Expand Up @@ -732,7 +733,7 @@ export const hasKeyRelationship = (subject: string, relationship: KeyRelationshi

if (problems.length >= 1)
return pushError(state, `Property "${subject}" ${spec.message} ${plural(problems.length, `property`, `properties`)} ${problems.map(name => `"${name}"`).join(`, `)}`);

return true;
},
})
Expand Down
6 changes: 6 additions & 0 deletions tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"target": "es2020"
}
}
4 changes: 4 additions & 0 deletions tests/type-guards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ import * as t from '../sources';
if (t.isLiteral(42)(foo)) {
const bar: 42 = foo;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way to remove the messages at the top? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I tried using a nested tsconfig.json, but it only gets rid of the editor warning, so it's still present if type-checking from the root. Maybe some magic with project references? Or should we just add a @ts-expect-error to the line above?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best is to use ES2020 in the general tsconfig.json, and create a tsconfig.build.json that extends the main one but downgrades the target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can't set ES2020 as the target for development, as TS won't transpile optional chaining anymore, which isn't supported by Node 12.

if (t.isLiteral(42n)(foo)) {
const bar: 42n = foo;
}
}

(foo: unknown) => {
Expand Down