Skip to content

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 25, 2025

1. Explain what the PR does

b061915 chore(build): use multiarch dir when available

2. Explain how to test it

3. Other comments

@geyslan geyslan self-assigned this Jun 25, 2025
@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 16:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new composite GitHub Action to automatically create missing header symlinks and invokes it in CI.

  • Introduce a fix-headers action to symlink missing asm/errno.h from asm-generic
  • Insert Fix Headers step after dependencies installation in multiple CI jobs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/pr.yaml Added - name: Fix Headers step that uses the new action in each job
.github/actions/fix-headers/action.yaml New composite action creating symlinks for missing asm headers
Comments suppressed due to low confidence (3)

.github/workflows/pr.yaml:110

  • This step runs unconditionally; on non-Linux runners it will fail due to missing /usr/include paths. Add if: runner.os == 'Linux' to guard execution.
      - name: Fix Headers

.github/workflows/pr.yaml:110

  • [nitpick] The Fix Headers step is duplicated across multiple jobs. Consider using YAML anchors or a reusable workflow to DRY up this configuration.
      - name: Fix Headers

.github/actions/fix-headers/action.yaml:11

  • Before creating symlinks, verify that the source directory /usr/include/asm-generic exists to avoid errors if it's missing.
        if [ ! -f /usr/include/asm/errno.h ]; then

@geyslan geyslan force-pushed the geyslan/fix-headers branch from f6b0af7 to 52c2414 Compare June 25, 2025 16:56
@geyslan geyslan requested a review from yanivagman June 25, 2025 17:08
@geyslan geyslan force-pushed the geyslan/fix-headers branch from 52c2414 to 13d8048 Compare June 25, 2025 17:45
@geyslan geyslan changed the title chore(ci): add action to fix missing includes chore(build): use multiarch dir when available Jun 25, 2025
@geyslan geyslan force-pushed the geyslan/fix-headers branch from 13d8048 to b061915 Compare June 25, 2025 17:52
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geyslan
Copy link
Member Author

geyslan commented Jun 25, 2025

/fast-forward

@github-actions github-actions bot merged commit b061915 into aquasecurity:main Jun 25, 2025
36 of 41 checks passed
@geyslan geyslan deleted the geyslan/fix-headers branch June 25, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants