fix(controlplane): filter unnecessary enriches #4193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition for enrichment in the control plane was faulty. It relied on the previous check for container relevant cgroups + not dead dirs. This, however, is obviously not enough. Therefore the condition for enrichment trigger now includes checking if the cgroup is a container's root directory.
Member
|
It arose in upcoming changes: https://github.com/aquasecurity/tracee/actions/runs/9973741398/job/27564629591?pr=4191#step:5:1455 {"level":"error","ts":1721217866.2903428,"msg":"error enriching container in control plane","error":"containers.(*Containers).EnrichCgroupInfo: cgroup 4633: no containerId (path /system.slice/motd-news.service)","cgroup_id":4633} |
Collaborator
Author
|
Possibly relevant #3870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
613986a fix(controlplane): filter unnecessary enriches
2. Explain how to test it
tracee -o jsondocker run --rm -d ubuntuEnrichment should work as before, with no new errors.
3. Other comments