Tidying Policy Manager #4165
Merged
Tidying Policy Manager #4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place PolicyManager in its proper home, the policy package.
Member
Author
|
This encompasses #4163. |
- Remove Snapshot() use. In the future it could be managed by the policy manager itself. - After PolicyManager initialization (first stages), Policies are not accessed directly anymore, but through the PolicyManager. - t.config.Policies is now only transient and used for PolicyManager initialization. - Policy version is deprecated and to be removed soon.
geyslan
force-pushed
the
tidy-policy-manager
branch
from
9341d35 to
93aaaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
93aaaf9 chore: tidy up policy manager and related code
857d8ed chore(policy): change manager mutex type to rw
209a44f chore: move policy manager into policy pkg
9341d35 chore: tidy up policy manager and related code
209a44f chore: move policy manager into policy pkg
2. Explain how to test it
3. Other comments