-
Notifications
You must be signed in to change notification settings - Fork 473
fix(ci): make release rule to have prerequisites #4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes ensure that the 'release' rule will require the other rules to be executed (splitting the commands into different rules). This way, if any some of the rules fail, the build will be aborted right away.
rscampos
approved these changes
Jun 21, 2024
Collaborator
rscampos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Jun 21, 2024
Continuation of aquasecurity#4141.
geyslan
added a commit
that referenced
this pull request
Jun 22, 2024
These changes ensure that the 'release' rule will require the other rules to be executed (splitting the commands into different rules). This way, if any some of the rules fail, the build will be aborted right away. commit: 86c2c16 (main), cherry-pick
geyslan
added a commit
that referenced
this pull request
Jun 22, 2024
geyslan
added a commit
that referenced
this pull request
Jun 22, 2024
* chore(ci): use dev tag for docker image building (#4138) When SNAPSHOT=1, the local docker image will be tagged with dev tag to differentiate it from the official release which is tagged with the latest tag. commit: 1085fc5 (main), cherry-pick * chore: install last version of golang commit: 6c111b4 (main), cherry-pick * chore: golang binary move to tmp commit: 221b0ac (main), cherry-pick * fix: arm64 clang issue commit: 6cc06b2 (main), cherry-pick * fix(ci): make release rule to have prerequisites (#4141) These changes ensure that the 'release' rule will require the other rules to be executed (splitting the commands into different rules). This way, if any some of the rules fail, the build will be aborted right away. commit: 86c2c16 (main), cherry-pick * fix(build): extract OPA 0.66 from OPA dev image This workaround is required since OPA 0.65.0 (latest published release) has cve-2024-24790. After solved we can rollback to the previouw installation method. commit: ef7d74e (main), cherry-pick * fix(build): mv gh release logic to release rule (#4145) Continuation of #4141. commit: 6f94719 (main), cherry-pick --------- Co-authored-by: Raphael Campos <[email protected]>
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Jun 24, 2024
This fixes issues that arose after applying the previous fix aquasecurity#4141.
geyslan
added a commit
that referenced
this pull request
Jun 24, 2024
This fixes issues that arose after applying the previous fix #4141.
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Jun 24, 2024
This fixes issues that arose after applying the previous fix aquasecurity#4141. commit: d83c07b (main), cherry-pick
geyslan
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
82336fe fix(ci): make release rule to have prerequisites
2. Explain how to test it
3. Other comments