Skip to content

Conversation

@oshaked1
Copy link
Contributor

1. Explain what the PR does

Add test for security_path_notify event to PR workflow.

@oshaked1
Copy link
Contributor Author

The security_path_notify function was introduced in kernel version 5.4. Currently there is no method to conditionally load probes based on kernel version, so the test fails on incompatible kernels.

@geyslan
Copy link
Member

geyslan commented Apr 3, 2024

https://github.com/aquasecurity/tracee/actions/runs/8373435136/job/22926492619?pr=3926#step:5:1468

INFO: SECURITY_PATH_NOTIFY: FAILED, stderr from tracee:
{"level":"warn","ts":1711017749.6577032,"msg":"Cancelling event and its dependencies because of missing probe","missing probe":103,"event":"security_path_notify","error":"probes.(*TraceProbe).attach: symbol not found: security_path_notify"}

@oshaked1 is this PR a demonstration of the lack of probes loading by kernel version? If so, please open an issue referring this, so we can close it for now.

@AlonZivony is this related to your work on dependencies?

@AlonZivony
Copy link
Contributor

@AlonZivony is this related to your work on dependencies?

Yea, it is partly related.
We will need some mechanism to load only needed programs. It will use the dependencies mechanism that I created.
Afterwards we will use the fallback mechanism I want to merge using the dependencies mechanism to load other programs in the case of failure.

@oshaked1 oshaked1 force-pushed the security_path_notify branch from 060bd0a to cf8478e Compare December 11, 2024 09:46
@oshaked1 oshaked1 marked this pull request as ready for review December 11, 2024 09:47
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanivagman yanivagman merged commit 09e7d60 into aquasecurity:main Dec 11, 2024
31 checks passed
@oshaked1 oshaked1 deleted the security_path_notify branch December 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants