Skip to content

Conversation

@philalex
Copy link

@philalex philalex commented May 15, 2018

Do case insensitive comparaison for booleans.
Code could be rewritten like:

value := strings.ToLower(flagVal)
if value != "false" && value != "true" {
          value = flagVal
}
result = value == t.Compare.Value

But i don't like this style ...

@ttousai
Copy link
Contributor

ttousai commented May 15, 2018

Thanks @philalex

LGTM

@lizrice lizrice merged commit 82b1e05 into aquasecurity:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants