Skip to content

Feat: browser extensions #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 27, 2021
Merged

Feat: browser extensions #63

merged 12 commits into from
Aug 27, 2021

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Aug 23, 2021

浏览器插件管理

Preview:
image

目前浏览器插件不能自动安装，只能用户手动安装。对于能访问应用商店的用户，则直接在应用商店安装插件：
image

对于不能访问应用商店的用户，则使用本地安装插件方式：
image

@luhc228 luhc228 self-assigned this Aug 23, 2021
@luhc228 luhc228 requested a review from fyangstudio August 23, 2021 10:25
@luhc228 luhc228 changed the base branch from release-next to feat/mac-app August 23, 2021 11:54
fyangstudio
fyangstudio reviewed Aug 24, 2021
View reviewed changes
main/data/data.json Outdated
"extensions": [
{
"title": "React Developer Tools",
"name": "React Developer Tools",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name 和 title 都是一样的？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. 我现在把 name 字段改成 id，会更合适。现在看来 title 和 name 有点重复了。

fyangstudio
fyangstudio reviewed Aug 24, 2021
View reviewed changes
main/data/data.json
"link": "https://chrome.google.com/webstore/detail/octotree-github-code-tree/bkhaagjahfmjljalopjnoealnfndnagc",
"icon": "https://img.alicdn.com/imgextra/i2/O1CN01z5X6661G0WUsozqTi_!!6000000000560-2-tps-128-128.png",
"downloadUrl": "https://iceworks.oss-cn-hangzhou.aliyuncs.com/toolkit/packages/chrome-extensions/Octotree-GitHub-code-tree_v7.0.7.crx",
"version": null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version null 那还需要这个字段吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先留着，后面可能有用

fyangstudio
fyangstudio reviewed Aug 24, 2021
View reviewed changes
renderer/src/pages/BrowserExtension/components/ExtensionList/index.tsx Outdated

const { extensionsInfo, installStatuses } = state;

const INSTALL_EXTENSION_CHANNEL = 'install-browser-extension';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

常亮 直接放最上头

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. 其他也改过来了

Base automatically changed from feat/mac-app to release-next August 24, 2021 07:07
@luhc228 luhc228 merged commit f788cb4 into release-next Aug 27, 2021
@luhc228 luhc228 deleted the feat/browser-extension branch August 27, 2021 03:38
@luhc228 luhc228 mentioned this pull request Aug 30, 2021
Merged
5 tasks
luhc228 added a commit that referenced this pull request Sep 1, 2021
@luhc228
Release 0.3.0 (#60)
3980125 
* Feat: mac app (#62)

* Feat: browser extensions (#63)

* Feat: support install tnpm or cnpm (#64)

* feat: smaller window size (#65)

* chore: update app name and readme (#66)

* fix: electron not found in prod (#67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyangstudio fyangstudio fyangstudio approved these changes

Assignees

@luhc228 luhc228

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luhc228 @fyangstudio