Skip to content

Endless Loop when Scene fails on_render_begin() #2919

@JaanWilli

Description

@JaanWilli

This issue occured while working on PR #2914, where the camera returns false in on_render_begin() when there are errors. In such a case, and endless loop is entered that infinitely calls on_render_begin(). All other cameras always return true and therefore never run into this problem, but the issue can easily be reproduced by forcing a return false.

It appears that the MasterRenderer skips the frame, if the scene entities failed to perform on_render_begin() (see here). It does so by returning renderer_controller.get_status(), which is ContinueRendering, but this is what causes the infinite loop. In my eyes, AbortRendering should be returned instead, like is done a bit further below.

Is there a reason that I am missing, why the rendering process should not be aborted here?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions