Skip to content

Conversation

@thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Sep 8, 2025

No description provided.

@thomasvl thomasvl added the semver/none No version bump required. label Sep 8, 2025
@thomasvl thomasvl requested a review from FranzBusch September 8, 2025 20:50
@thomasvl
Copy link
Collaborator Author

thomasvl commented Sep 8, 2025

@FranzBusch Looks like you might have required all the current checks for PRs as the 6.1.2 is listed even though it doesn't exist any more with this change. Is there a way to change the configuration on github so it won't fail the checks like this?

@thomasvl
Copy link
Collaborator Author

thomasvl commented Sep 8, 2025

We could delete the patch version from our numbers so we just list major.minor and the links will lets things float, but if something ever breaks on a patch version, we won't really see it without digging into log and by looking to see if a new patch rolled out since the last time out CL ran.

We'd also still have this sorta problem of the github config needing to be be updated when we add/remove versions (to require the new one or drop the old one).

@thomasvl thomasvl requested review from Lukasa and tbkka September 9, 2025 12:21
@thomasvl
Copy link
Collaborator Author

thomasvl commented Sep 9, 2025

@FranzBusch Looks like you might have required all the current checks for PRs as the 6.1.2 is listed even though it doesn't exist any more with this change. Is there a way to change the configuration on github so it won't fail the checks like this?

@Lukasa @tbkka incase either of you can tweak the config on github for this.

@Lukasa
Copy link
Contributor

Lukasa commented Sep 9, 2025

Amended, you're good to go.

@thomasvl
Copy link
Collaborator Author

thomasvl commented Sep 9, 2025

Amended, you're good to go.

Thanks, still need one of you to review. :)

For future reference, is there a way to not have to do this tweaking with each release? Do we want to switch to major.minor and float like I mentioned?

@Lukasa
Copy link
Contributor

Lukasa commented Sep 9, 2025

That's what we do on swift-nio and friends, we just float the minor version.

@thomasvl thomasvl merged commit 4d9df91 into apple:main Sep 9, 2025
13 checks passed
@thomasvl thomasvl deleted the swift_6_1_3 branch September 9, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants