Moved xpath into boostrap java

[Jonahss]

And removed complex-find while at it.

Submitting to @bootstraponline for review.

I'm working now on changing the getPageSource code to reuse the same code here.

[bootstraponline]

authorship is tracked via git

[Jonahss]

Oops yeah. Those get added by my ide by default.

[jlipps]

LGTM. Pretty sure @bootstraponline will ask you to remove the "created by jonahss" comments though :-)

[bootstraponline]

I'd like to do a better review on this once I'm back from the roadshow on Friday.

[0x1mason]

Do you know why?

[Jonahss]

Because android UiAutomator library is notoriously flaky and error prone :(

[bootstraponline]

ok. I think this is fine to merge. jlipps wants to release 1.2.2. I'll do a proper review later and that doesn't block the pr.

[bootstraponline]

also remember to squash to one commit

[bootstraponline]

why do we need continue?

[Jonahss]

I probably had code following the try/catch, which I later deleted.
It's nice to have the continue in there, so if a developer casually added some logic to that iteration, they wouldn't accidentally forget to add it.

[bootstraponline]

I don't think we should add a continue unless it's necessary. It's a for loop so we're going to continue either way.

[Jonahss]

looks like travis caught an error. I removed the npm dependency on xpath without realizing that iOS needs it.
The library is kind of buggy though :(

I'll squash these commits. but does anything else need to be changed for merge?

We can create a separate issue for adding stack-trace to errors.

[jlipps]

Looks good to me! Do all the appium xpath tests still pass with this?

[Jonahss]

squashed.

Yup, appium xpath tests pass.

[bootstraponline]

I'll squash these commits. but does anything else need to be changed for merge?

I think it's fine. I don't think we need the continue, otherwise 👍 from me.

[jlipps]

agreed about the interesting continue. let's axe that and merge this baby.

[Jonahss]

removed that continue statement.
added a comment about our giant Exception catchall

[bootstraponline]

@Jonahss hey, you said you would squash.

[bootstraponline]

I guess it's about 3 different issues so the different commits are fine.

[bootstraponline]

I had time to test this today and it all seems to be working. It'd be nice to have the Java bootstrap tests run automatically if that's not already setup.

[Jonahss]

Agreed. I'll create an issue.

On Sun, Aug 24, 2014 at 7:42 PM, bootstraponline [email protected]
wrote:

I had time to test this today and it all seems to be working. It'd be nice
to have the Java bootstrap tests run automatically if that's not already
setup.

—
Reply to this email directly or view it on GitHub
#3428 (comment).