Pro 8152 add external front #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR adds
annotateWidgetForExternalFront()
methods to the two modules. This allows the anchors budle to be used in an Astro project without custom code. It depends on changes in core and the@apostrophecms/apostrophe-astro
module. Closes PRO-8152What are the specific steps to test this change?
For example:
starter-kit-astro-essentials
pro-8152-anchors
branches of both core and@apostrophecms/apostrophe-astro
in the backend and frontend portions of the project, respectively.anchorAttribute
option. Confirm the attribute changes in the markup.What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: