Include src for source maps #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hwillson mind taking a look at this? |
benjamn
approved these changes
Jun 23, 2021
Member
benjamn
left a comment
benjamn
left a comment
There was a problem hiding this comment.
@maclockard I have no problem with publishing the src/ directory. Do you think this PR by itself will make source maps work as you hoped, or are there any other necessary steps?
Contributor
Author
|
I believe its all that's needed since y'all already publish source maps with correct paths! |
Contributor
Author
|
@benjamn how do I get the build tests to run against this PR? |
benjamn
force-pushed
the
ml/fix-source-maps
branch
from
71eb28a to
37b591b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #389