fix(TS): replace 'any' with types for event data (listener parameter) #3027
+24
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @metalwarrior665, is this a draft because it's still a work in progress or are you already asking for feedback? |
vladfrangu
requested changes
Jun 26, 2025
| export abstract class EventManager { | ||
| protected events = new AsyncEventEmitter(); | ||
| export abstract class EventManager<SystemInfo> { | ||
| protected events = new AsyncEventEmitter<EventTypeToArgs<SystemInfo>>(); |
There was a problem hiding this comment.
One of these days we ought to move to having the class as the EventEmitter, but not today :D
| import { EventManager, EventType } from './event_manager'; | ||
|
|
||
| export class LocalEventManager extends EventManager { | ||
| interface LocalSystemInfo { |
There was a problem hiding this comment.
Suggested change
| interface LocalSystemInfo { | |
| export interface LocalSystemInfo { |
…etails in EventManager
|
@janbuchar I'm asking for feedback. I kept it as Draft mainly to make sure we resolve the breaking change part first. Can make it Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on apify/apify-sdk-js#404, I realized all event data are
any, this is an attempt to correct that. It is just a draft idea with many problems:PlatformEventManagerSo take this more as a PoC idea. The reason I got to this is that I wanted to handle
Actor.on('persistState')but do extra step if there isisMigratingorisAbortingso not a huge use-case to have the types correct.