Skip to content

refactor: remove manual deleteRequestLock from BasicCrawler [#2840] #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove manual deleteRequestLock from BasicCrawler [#2840] #3014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/basic-crawler/src/internals/basic-crawler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,13 +1550,9 @@ export class BasicCrawler<Context extends CrawlingContext = BasicCrawlingContext
this.crawlingContexts.delete(crawlingContext.id);

// Safety net - release the lock if nobody managed to do it before
if (isRequestLocked && source instanceof RequestProvider) {
try {
await source.client.deleteRequestLock(request.id!);
} catch {
// We don't have the lock, or the request was never locked. Either way it's fine
}
}
// Removed manual deleteRequestLock as this should be handled by markRequestHandled()
// See: https://github.com/apify/crawlee/issues/2840

}
}

Expand Down