Replace optparse with argparse #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
William-Brown5515
force-pushed
the
275-optparse-deprecation
branch
from
4f7c94b to
94983ed
Compare
tofu-rocketry
requested changes
Sep 11, 2024
William-Brown5515
force-pushed
the
275-optparse-deprecation
branch
from
94983ed to
869ae73
Compare
tofu-rocketry
requested changes
Sep 11, 2024
Member
tofu-rocketry
left a comment
tofu-rocketry
left a comment
There was a problem hiding this comment.
Almost there. Just note that it's best to just add commits, rather than amend, while code is under review as it makes it easier to see what's changed between each review.
tofu-rocketry
approved these changes
Sep 11, 2024
tofu-rocketry
approved these changes
Sep 11, 2024
Optparse is deprecated - no longer developed. Mostly a like-for-like replacement, but we use vars on the argparse object to output the values in a similar way to optparse. The old version option on the constructor is unavailable, and so it has been replaced by adding an argument with the 'version' action.
Removal of 'optional' on deprecated arguments, using only 'ver' for version numbers, removal of unnecessary parentheses.
tofu-rocketry
force-pushed
the
275-optparse-deprecation
branch
from
74ec5c7 to
6e623eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optparse is deprecated - no longer developed. Mostly a like-for-like replacement, but we use vars on the argparse object to output the values in a similar way to optparse.
The old version option on the constructor is unavailable, and so it has been replaced by adding an argument with the 'version' action.
Resolves #275
Resolves GT-540