Replaced the Popen commands in check_cert_key to use OpenSSL #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
force-pushed
the
Replace-popen-to-OpenSSL-313
branch
from
9e8f475 to
db5763f
Compare
tofu-rocketry
requested changes
Apr 10, 2024
Member
tofu-rocketry
left a comment
tofu-rocketry
left a comment
There was a problem hiding this comment.
The docstring for the method could do with updating as it still refers to using "openssl directly", when it's now done via pyopenssl.
replaced the Popen commands in check_cert_key to use OpenSSL
Will-Cross1
force-pushed
the
Replace-popen-to-OpenSSL-313
branch
from
db5763f to
7fe9cee
Compare
tofu-rocketry
approved these changes
Apr 10, 2024
William-Brown5515
pushed a commit
to William-Brown5515/ssm
that referenced
this pull request
Nov 20, 2024
Refactor records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #313
Solves original problem of a warning returned by Popen as an error and causing the function to return False
Improves the variable names from pubkey1 and pubkey2 to help show where the key came from