Remove python-daemon as a requirement #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
force-pushed
the
issue-80
branch
from
7c785dc to
4b7935d
Compare
Member
|
That's the rebase done. |
As there's no consistent way of handling optional dependencies across packaging systems, python-daemon should just be left out as a hard requirement.
As python-daemon is an optional requirement, we handle the case where it is not installed but it's reuqired by supsequent code (when receiving).
tofu-rocketry
force-pushed
the
issue-80
branch
from
4b7935d to
f815708
Compare
tofu-rocketry
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80
As there's no consistent way of handling optional packages across packaging systems, python-daemon should just be left out.