ZOOKEEPER-3433 zkpython build broken after maven migration

[phunt]

Fixed the build and test infrastructure for zkpython.

Verified the build and tests all passing under both ubuntu and macos.

Change-Id: I3c80774a2712f280d1f14739d1eb78baa066fdc6

[eolivelli]

Isn't any 'target' directory name?
Did you build with raw 'make' the c client?

There are multiple ways to build the C client

[phunt]

I used ant to build the c client as maven doesn't seem to be working (the c client is not being built even with "full-build" profile). That's the way it was always done on the past - just continuing until we have a maven based approach. So with this we get back to status quo - after the directory structure changes for maven I mean.

I did a "ant clean compile compile-native" at the toplevel, then "ant compile" and "ant test" within the zookeeper-contrib-zkpython directory.

[phunt]

@eolivelli can you +1 this (or @anmolnar ) or give me addl feedback? I have some addl patches for python3 that i'd like to land. thanks.

[eolivelli]

@phunt we should commit #993 that is fixing the C client build as said on the ML

[eolivelli]

How can I test this patch locally?

[phunt]

we should commit #993 that is fixing the C client build as said on the ML

I provided some feedback. Let's work on #993 separately and not block progress here as the legacy (pre-mvn) is still working.

[phunt]

How can I test this patch locally?

I did a "ant clean compile compile-native" at the toplevel, then "ant compile" and "ant test" within the zookeeper-contrib-zkpython directory.

You need to have python2 installed and the dev libraries available.

That runs all the tests for zkpython (with this patch applied)

[nkalmar]

Tested before (failed at ant compile in zkpython) and after patch. Works fine on Ubuntu with python2.
+1

[nkalmar]

Committed to master and 3.5 (tested, this patch also solves it on 3.5, which has the same problem)