YETUS-1145. add rstcheck #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndimiduk
reviewed
May 2, 2022
ndimiduk
requested changes
May 2, 2022
|
|
||
| for i in "$@"; do | ||
| case ${i} in | ||
| --rstcheck=*) |
There was a problem hiding this comment.
This should be --rstcheck-cmd, so as to be consistent with our other plugins that permit specifying the executable path?
There was a problem hiding this comment.
precommit is wildly inconsistent here. Some use --foo-cmd= and some use --foo=. There should really be a follow-on JIRA to make these consistent.
I wanted to cover rstcheck support for i18n while I was still thinking about it. Now that the i18n PR is merged, I've rebased on top of the current main in order to pull it in. |
ndimiduk
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.