Skip to content

Conversation

@kaijchen
Copy link
Member

What changes were proposed in this pull request?

Add "Apache" in the title and improve the description.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

See https://github.com/kaijchen/incubator-uniffle/tree/readme#apache-uniffle-incubating

@jerqi jerqi changed the title [Docs] Update title and description in README [DOC] Update title and description in README Jul 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #94 (ca77f3c) into master (82d1046) will decrease coverage by 0.88%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     56.33%   55.44%   -0.89%     
+ Complexity     1174     1101      -73     
============================================
  Files           149      140       -9     
  Lines          7977     7607     -370     
  Branches        765      735      -30     
============================================
- Hits           4494     4218     -276     
+ Misses         3241     3155      -86     
+ Partials        242      234       -8     
Impacted Files Coverage Δ
...org/apache/uniffle/server/ShuffleFlushManager.java 76.70% <0.00%> (-1.71%) ⬇️
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️
...org/apache/spark/shuffle/writer/AddBlockEvent.java
...pache/spark/shuffle/writer/WriteBufferManager.java
...org/apache/spark/shuffle/RssSparkShuffleUtils.java
...e/spark/shuffle/reader/RssShuffleDataIterator.java
...che/spark/shuffle/writer/BufferManagerOptions.java
.../java/org/apache/spark/shuffle/RssSparkConfig.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
.../org/apache/spark/shuffle/writer/WriterBuffer.java
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 5b144a6 into apache:master Jul 28, 2022
@kaijchen
Copy link
Member Author

Thanks @jerqi for the review.

@kaijchen kaijchen deleted the readme branch July 28, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants